Hi Jon Olav,
thanks for the review.
On 11/11/2010 03:19 PM, Jon Olav Hauglid wrote:
> Did you consider multi_delete::send_eof() and
> Select_fetch_protocol_binary::send_eof()?
multi_delete already has error handling code. There is already a test in
trigger.test that checks that it works correctly. In the latest patch I also
added the is_error() check to Select_fetch_protocol_binary::send_eof().
>> @ mysql-test/r/errors.result
>> Add test for BUG#54812
>> @ mysql-test/t/errors.test
>> Add test for BUG#54812
>
> I don't think you should use errors.test for the test case.
> Since you use privileges, it won't work with embedded server.
Good point.
> I also suggest disconnecting con1 to return to the state before your
> test started. We tend to use:
> connection con1;
> disconnect con1;
> --source include/wait_until_disconnected.inc
Hmm... never did that before, but it sounds like a good idea. Done.
--
Jørgen Løland | Senior Software Engineer | +47 73842138
Oracle MySQL
Trondheim, Norway
