From: Alexander Nozdrin Date: November 10 2010 2:20pm Subject: Re: bzr commit into mysql-trunk-bugfixing branch (mats.kindahl:3330) Bug#58109 List-Archive: http://lists.mysql.com/commits/123425 Message-Id: <4CDAAA16.7050902@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Hi Mats, thanks for working on this. I think, the patch is Ok to push. I'd emphasize in a CS comment, that documentation should be updated: file specified in the '--defaults-file' option will not be loaded anymore if conf_file (or MYSQL::options::my_cnf_file for clients) is an absolute file path. On 10.11.2010 14:48, Mats Kindahl wrote: > #At file:///home/bzr/bugs/b57108-trunk-fixing/ based on revid:mats.kindahl@stripped > > 3330 Mats Kindahl 2010-11-10 > Bug #58109: Function my_load_defaults() does not read > correct file > > When passed an absolute filename, my_load_defaults() > is supposed to read only that file, but instead it > reads values from the defaults file found in a previous > execution of the function (which is saved in > my_defaults_file). > > This patch fixes this by changing order of checks in > my_search_option_files() so that it first checks if an > absolute path was supplied, and in that case uses that > file only.