List:Commits« Previous MessageNext Message »
From:Dmitry Shulga Date:November 10 2010 5:49am
Subject:bzr commit into mysql-5.1-bugteam branch (Dmitry.Shulga:3501) Bug#57386
View as plain text  
#At file:///Users/shulga/projects/mysql/5.1-bugteam-bug57386/ based on revid:davi.arnaut@stripped

 3501 Dmitry Shulga	2010-11-10
      Fixed Bug#57386 - main.execution_constants segfault on MIPS64EL.
     @ sql/item_func.cc
        Item_func::fix_fields modified: increased minimal required stack
        size in call to check_stack_overrun().

    modified:
      sql/item_func.cc
=== modified file 'sql/item_func.cc'
--- a/sql/item_func.cc	2010-10-05 08:11:56 +0000
+++ b/sql/item_func.cc	2010-11-10 05:49:37 +0000
@@ -157,7 +157,14 @@ Item_func::fix_fields(THD *thd, Item **r
   used_tables_cache= not_null_tables_cache= 0;
   const_item_cache=1;
 
-  if (check_stack_overrun(thd, STACK_MIN_SIZE, buff))
+  /*
+    Use stack limit of STACK_MIN_SIZE * 2 since
+    on some platforms a recursive call to fix_fields
+    requires more than STACK_MIN_SIZE bytes (e.g. for
+    MIPS, it takes about 22kB to make one recursive
+    call to Item_func::fix_fields())
+  */
+  if (check_stack_overrun(thd, STACK_MIN_SIZE * 2, buff))
     return TRUE;				// Fatal error if flag is set!
   if (arg_count)
   {						// Print purify happy


Attachment: [text/bzr-bundle] bzr/dmitry.shulga@oracle.com-20101110054937-qqndtntsaes91tpl.bundle
Thread
bzr commit into mysql-5.1-bugteam branch (Dmitry.Shulga:3501) Bug#57386Dmitry Shulga10 Nov