List:Commits« Previous MessageNext Message »
From:Libing Song Date:November 8 2010 10:07am
Subject:Re: bzr commit into mysql-trunk-bugfixing branch (zhenxing.he:3323)
Bug#56649
View as plain text  
Hi Zhenxing,
Nice work!
Patch approved.

On Thu, 2010-11-04 at 07:04 +0000, He Zhenxing wrote:
> #At file:///media/sdb2/hezx/work/mysql/bzr/b56649/trunk-bugfixing/ based on
> revid:horst.hunger@stripped
> 
>  3323 He Zhenxing	2010-11-04
>       BUG#56649 Valgrind warnings for memory leak in semisync plugin (Delegate
> class)
>       
>       The Observer_info object allocated when INSTALL semisync plugin was
>       not free after UNINSTALL the plugin.
>       
>       Fixed the problem by free the object when UNINTSALL.
> 
>     modified:
>       sql/rpl_handler.h
> === modified file 'sql/rpl_handler.h'
> --- a/sql/rpl_handler.h	2010-07-02 18:15:21 +0000
> +++ b/sql/rpl_handler.h	2010-11-04 07:04:22 +0000
> @@ -73,7 +73,10 @@ public:
>      while (info && info->observer != observer)
>        info= iter++;
>      if (info)
> +    {
>        iter.remove();
> +      delete info;
> +    }
>      else
>        ret= TRUE;
>      unlock();
> 
> text/bzr-bundle type attachment
> (bzr/zhenxing.he@stripped)
> # Bazaar merge directive format 2 (Bazaar 0.90)
> # revision_id: zhenxing.he@stripped
> # target_branch: file:///media/sdb2/hezx/work/mysql/bzr/b56649/trunk-\
> #   bugfixing/
> # testament_sha1: b4607f757fd5d5669ca1c98e172f2f1df851a5c2
> # timestamp: 2010-11-04 15:04:33 +0800
> # base_revision_id: horst.hunger@stripped\
> #   qvsw6yhk68qe8edq
> # 
> # Begin bundle
> IyBCYXphYXIgcmV2aXNpb24gYnVuZGxlIHY0CiMKQlpoOTFBWSZTWeapvxcAAYNfgFAQWGP//3fl
> jxC////6UAPNPdQ73jXpcrzcJKETJ6p5Mp4hkKfpT9CTaekmTwoA2po9Q9QZJGR6CYRKYw1IyMID
> QANAMgQTU9TQIMgAAYgAAAaAAYoEZU8JqB+pGQDEAAMgB6gAlCSZNNoTQ0J6Mk0xNBkAAAA0csMd
> Nn+6t/H5Ka6jO5o57ZkjHXW6CyF3rmpQOXOLLyjYwhY5C54RdpEYCWSGouTXGgpswc7KB+T6hdDQ
> 236rBnABjSTg0c3CQMfNm546ZPTcNYLhmKtdkQ8yiPWAro7ZxRdqrpwQ0ZckAjJjWZKRVOh7IrSF
> KdjJCpghoi+5qBRKBrLdCiKWDJAmOBo5EZQZiuAQ2OQIN4xWZXjAgUyLsFasasMuwfc/pfGZa+Xj
> StNshaNAB+eIRE3XlMMJEYKqVnEqYEWWXARMI98IQ1Fq5LdohBgzHGoO18jALiBoK0jC6dWYDkgC
> w7BpcCqBWjQbBRgyh+5CwVS5IbQP5PhZeytHo9qRZMImhQ6XYoIrhm5WDTgWVsVaFb3mOSE5dfAZ
> 1YRClJXzmahLArV7WQHcL+RzZ3otz6jA4I8/4G7fmBazteIF8BLSwYKRzXKB81PQEsVlNMEUJLJA
> QAZWUxmhkCjFRQpgRFX24p90aCbxeytBJcfp4Od8vuvHSfUvF5fVAVBRyPA3zVPXuaHHjCMC8t06
> DXk23HnLHqxFoqJ8AQb+nDBVVFUqC9ikZMjyMsBy8m5o8hhbeOF4mUv0G332m7S+I8VKQdOOfYjQ
> Z/OMuf3FgcY7rGSN1pE7yUYRMkxbGuGPhUKoa+UQVTgikO8CxdGm1Ph9JHETAmYbrcanrgMmMuGN
> wRRl0lOvCGJ1PxMfV9huWgldbqoZN8o8WZ9Hezw9GnS6PWWWDzqmIwFMKRVOoSKPKu/IRyBbR2gx
> ld3iVwxkp2DGt8pP02+GwWObQoE9hC1wE7kNC8JZXTalsKw6rlYoUpd51tS5qBd2BZAjVOkn+GJM
> h1FSaWVjCPvDsww3oJPOuiLEEomoNSbnQV75pLM8za05hJL4KbcgPB7BlMcyQm6zGWWnVWaUApGH
> USNwHDtGNTaxQLpyEuF8aRKIcEIKwEMOlwCl5CLmAF5VdLcG62REEUUAmJ1eWrq3wSINLiHdoBky
> JS6RTLezQVPEnxKqQEqMVhgbRXrUujpizEMpVscJ2BPAwsKRLCMbcgmGAy3TGOu95pjy5bsGe/8J
> iXo5jAM1hm5HSE7IM8t4CYiCSbF+0ooGoITUwDuWqbKm9nQLrn3M455jch9zYUmIA8GcyTWYML0m
> jEM6RtjuI68G3gSFLwTRALCkT1U9CjN4qchcJ8bPYaBmXbi0nU/4u5IpwoSHNU34uA==
> 
> 

-- 
Your Sincerely,
Libing Song
==================================
MySQL Replication Team
Software Engineer


Email : Li-Bing.Song@stripped
Skype : libing.song
MSN   : slb_database@stripped
Phone : +86 010-6505-4020 ext. 319
Mobile: +86 138-1144-2038
==================================

Thread
bzr commit into mysql-trunk-bugfixing branch (zhenxing.he:3323) Bug#56649He Zhenxing4 Nov
  • Re: bzr commit into mysql-trunk-bugfixing branch (zhenxing.he:3323)Bug#56649Libing Song8 Nov