List:Commits« Previous MessageNext Message »
From:Jon Olav Hauglid Date:November 8 2010 9:48am
Subject:bzr commit into mysql-5.1-bugteam branch (jon.hauglid:3555) Bug#45288
View as plain text  
#At file:///export/home/x/mysql-5.1-bugteam-gcov/ based on revid:dmitry.shulga@stripped

 3555 Jon Olav Hauglid	2010-11-08
      Bug #45288 pb2 returns a lot of compilation warnings
      
      GCOV builds were broken after the patch for Bug#57933
      which added add -Wdeclaration-after-statement to gcc builds.
      
      This patch fixes:
      stacktrace.c:328: warning: ISO C90 forbids mixed
      declarations and code
      
      No test case added.

    modified:
      mysys/stacktrace.c
=== modified file 'mysys/stacktrace.c'
--- a/mysys/stacktrace.c	2010-07-30 20:33:10 +0000
+++ b/mysys/stacktrace.c	2010-11-08 09:48:31 +0000
@@ -318,6 +318,9 @@ end:
 /* Produce a core for the thread */
 void my_write_core(int sig)
 {
+#ifdef HAVE_gcov
+  extern void __gcov_flush(void);
+#endif
   signal(sig, SIG_DFL);
 #ifdef HAVE_gcov
   /*
@@ -325,7 +328,6 @@ void my_write_core(int sig)
     information from this process, causing gcov output to be incomplete.
     So we force the writing of coverage information here before terminating.
   */
-  extern void __gcov_flush(void);
   __gcov_flush();
 #endif
   pthread_kill(pthread_self(), sig);


Attachment: [text/bzr-bundle] bzr/jon.hauglid@oracle.com-20101108094831-y9qeeowms2fj9ib8.bundle
Thread
bzr commit into mysql-5.1-bugteam branch (jon.hauglid:3555) Bug#45288Jon Olav Hauglid8 Nov