From: Tor Didriksen Date: November 5 2010 12:41pm Subject: Re: bzr commit into mysql-5.5-bugteam branch (guilhem:3115) Bug#57316 List-Archive: http://lists.mysql.com/commits/122947 Message-Id: <4CD3FB94.5010607@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit On 2010-11-05 12:25, Olav Sandstaa wrote: > Hi Guilhem, > > Thanks for making an alternative patch for implementing this. I prefer > this patch over the first you committed. > > The patch looks good and I have only one request: > > * Consider updating the "help text" for autocommit from "autocommit" > to something more descriptive, e.g. "Set default value for auto commit > (0 or 1)". > > OK to push. > > Olav I agree with Olav. BUT: please note that in next-mr, you can also say "true" or "on" rather than "1" -- didrik