Hi Mats,
On 11/02/2010 08:36 PM, Mats Kindahl wrote:
> On 11/02/2010 12:33 PM, Alfranio Correia wrote:
>> Hi Mats,
>>
>> Great work,
>>
>> Please, find in what follows some requests/suggestions to improve the
>> patch.
>>
>>
>> STATUS
>> ------
>>
>> Patch conditionally approved.
>>
>>
>> 3. Are the different return values used anywhere?
>> I don't think this is used anywhere:
>>
>> + RETURNS
>> + 0 All OK
>> + 2 Out of memory or path to long
>> + 3 Not able to get working directory
>> + */
>>
>> my_search_option_files -> fn_expand -> my_load_defaults/load_defaults
>
> Might be so, but this file is part of the generic mysys library, so
> returning error codes to distinguish what went wrong is prudent.
ok.
>
>> Besides, there are places where the return value is not verified.
>
> Verified in what sense? All the calls I find are aborting the server
> when there is an error code.
There are only two places:
./sql-common/client.c:1217: my_load_defaults(filename, groups, &argc, &argv,
NULL);
./libmysqld/lib_sql.cc:509: load_defaults("my", (const char **)groups, argcp, argvp);
Cheers.
