On 10/25/2010 06:29 AM, He Zhenxing wrote:
> Hi Luis,
> Thank you for the review!
> Luís Soares wrote:
>> Hi Zhenxing,
>> I will approved the patch, but I still wonder what has caused
>> this. Perhaps, we will get more detailed information if it
>> happens again after this patch is in.
> I'm not quite sure about the cause either, but since this was reported
> long ago, and that part of the code has been changed several times since
> then, so maybe the failure has been fix already. And I agree that if the
> failure happen again we can get more information after this patch.
Yes, I thought the same, so I was not so picky about it. I am good.
>> See some suggestions inline.
>> On 10/21/2010 07:05 AM, He Zhenxing wrote:
>>> #At file:///media/sdb2/hezx/work/mysql/bzr/b47027/next-mr-bugfixing/ based on
>>> 3328 He Zhenxing 2010-10-21
>>> BUG#47027 delegates_init() failure is not user friendly (usability
>> "Initialization of transaction delegates failed. Please, report a bug."
> Why add a comma after the Please? I'd like to use your sentence but
> without the extra comma.
I guess it's fine either as I can't really tell what's wrong or
right here :) . Do as you like.
Anyway, I would maybe ask Jon about it? I am no native
speaker, and I have see two conflicting rules already:
1. enclose please with commas in a sentence.
2. Use commas if please is at the end of the sentence. Don't
use commas if please is at the beginning of the sentence.