List:Commits« Previous MessageNext Message »
From:Magne Mæhre Date:October 21 2010 12:05pm
Subject:Re: bzr commit into mysql-next-mr-bugfixing branch (magne.mahre:3324)
WL#5265
View as plain text  
On 15/10/10 06:36, Alexander Nozdrin wrote:
> Hi Magne,
> 
> thank you for working on this!
> 
> I like the patch, but there is one thing I didn't get: from what
> I understood, version tags/numbers should be eliminated for all
> messages. If that's true, then why do we need major and minor version
> components in WARN_DEPRECATED() macro? It seems, we also have version
> tag (70000) in DEPRECATED() macro.
> 
> So, may be we can get rid of those version specificity in macros?

Hi Alik

These macros are currently used in asserts (both compile time and
runtime asserts) that verify that we haven't passed the specified
version.  While I agree that they're not of much use now, I am
reluctant to remove them.

Paul:  What do you think ?  Leave them in for now, and take them
       out later?

If you guys don't have any further comments, please tick off the "Done"
checkbox at:

https://intranet.mysql.com/worklog/Server-Deprecation/?catname=Server-Deprecation&tid=5265


Thanks

--Magne
Thread
bzr commit into mysql-next-mr-bugfixing branch (magne.mahre:3324) WL#5265Magne Mahre14 Oct
  • Re: bzr commit into mysql-next-mr-bugfixing branch (magne.mahre:3324)WL#5265Alexander Nozdrin15 Oct
    • Re: bzr commit into mysql-next-mr-bugfixing branch (magne.mahre:3324)WL#5265Magne Mæhre21 Oct
      • Re: bzr commit into mysql-next-mr-bugfixing branch (magne.mahre:3324) WL#5265Paul DuBois24 Oct
        • Re: bzr commit into mysql-next-mr-bugfixing branch (magne.mahre:3324)WL#5265Magne Mæhre24 Oct