bzr push into mysql-5.1-mtr branch (bjorn.munch:2942 to 2946)

[Bjorn Munch]

 2946 Bjorn Munch	2010-10-20
      Fixed wrong feof check in read_line, see 52019

    modified:
      client/mysqltest.cc
 2945 Bjorn Munch	2010-10-20
      Fixed missing cast of arg to my_mbcharlen

    modified:
      client/mysqltest.cc
 2944 Bjorn Munch	2010-10-20
      48863 followup: move an array declaration out from within if block

    modified:
      client/mysqltest.cc
 2943 Bjorn Munch	2010-10-20
      Bug #52019 main.mysqltest fails on new tests for lowercase_result
      Limited to actual bug fix, fixing a while condition
      Again confirmed on Linux PPC and on AIX 5.3

    modified:
      client/mysqltest.cc
 2942 Bjorn Munch	2010-10-19
      Bug #56654 pb2 log is very hard to read
      Added some more info in a number of fail cases
      (re-commit for administrative reasons)

    modified:
      mysql-test/mysql-test-run.pl
=== modified file 'client/mysqltest.cc'
--- a/client/mysqltest.cc	2010-10-01 09:00:18 +0000
+++ b/client/mysqltest.cc	2010-10-20 09:41:51 +0000
@@ -5721,7 +5721,7 @@ int read_line(char *buf, int size)
       /* Could be a multibyte character */
       /* This code is based on the code in "sql_load.cc" */
 #ifdef USE_MB
-      int charlen = my_mbcharlen(charset_info, c);
+      int charlen = my_mbcharlen(charset_info, (unsigned char) c);
       /* We give up if multibyte character is started but not */
       /* completed before we pass buf_end */
       if ((charlen > 1) && (p + charlen) <= buf_end)
@@ -5733,16 +5733,16 @@ int read_line(char *buf, int size)
 
 	for (i= 1; i < charlen; i++)
 	{
+	  c= my_getc(cur_file->file);
 	  if (feof(cur_file->file))
 	    goto found_eof;
-	  c= my_getc(cur_file->file);
 	  *p++ = c;
 	}
 	if (! my_ismbchar(charset_info, mb_start, p))
 	{
 	  /* It was not a multiline char, push back the characters */
 	  /* We leave first 'c', i.e. pretend it was a normal char */
-	  while (p > mb_start)
+	  while (p-1 > mb_start)
 	    my_ungetc(*--p);
 	}
       }
@@ -9781,6 +9781,7 @@ void free_pointer_array(POINTER_ARRAY *p
 void replace_dynstr_append_mem(DYNAMIC_STRING *ds,
                                const char *val, int len)
 {
+  char lower[512];
 #ifdef __WIN__
   fix_win_paths(val, len);
 #endif
@@ -9788,7 +9789,6 @@ void replace_dynstr_append_mem(DYNAMIC_S
   if (display_result_lower) 
   {
     /* Convert to lower case, and do this first */
-    char lower[512];
     char *c= lower;
     for (const char *v= val;  *v;  v++)
       *c++= my_tolower(charset_info, *v);

No bundle (reason: useless for push emails).