List:Commits« Previous MessageNext Message »
From:Davi Arnaut Date:October 18 2010 4:27pm
Subject:bzr commit into mysql-5.1-bugteam branch (davi:3533) Bug#45288
View as plain text  
# At a local mysql-5.1-bugteam repository of davi

 3533 Davi Arnaut	2010-10-18
      Bug#45288: pb2 returns a lot of compilation warnings on linux
      
      Enable the MySQL maintainer-specific development environment
      (which add various warning related options to the compiler
      flags) if debugging support is enabled.
     @ config/ac-macros/maintainer.m4
        Enable the maintainer mode if debug support is enabled.
     @ configure.in
        Move debug argument to before the maintainer mode check.

    modified:
      config/ac-macros/maintainer.m4
      configure.in
=== modified file 'config/ac-macros/maintainer.m4'
--- a/config/ac-macros/maintainer.m4	2010-09-24 12:36:31 +0000
+++ b/config/ac-macros/maintainer.m4	2010-10-18 16:27:10 +0000
@@ -8,7 +8,8 @@ AC_DEFUN([MY_MAINTAINER_MODE], [
     [AS_HELP_STRING([--enable-mysql-maintainer-mode],
                     [Enable a MySQL maintainer-specific development environment])],
     [USE_MYSQL_MAINTAINER_MODE=$enableval],
-    [USE_MYSQL_MAINTAINER_MODE=no])
+    [AS_IF([test "$with_debug" != "no"],
+      [USE_MYSQL_MAINTAINER_MODE=yes], [USE_MYSQL_MAINTAINER_MODE=no])])
   AC_MSG_RESULT([$USE_MYSQL_MAINTAINER_MODE])
 ])
 

=== modified file 'configure.in'
--- a/configure.in	2010-09-28 08:33:22 +0000
+++ b/configure.in	2010-10-18 16:27:10 +0000
@@ -103,6 +103,13 @@ AC_SUBST(SHARED_LIB_MAJOR_VERSION)
 AC_SUBST(SHARED_LIB_VERSION)
 AC_SUBST(AVAILABLE_LANGUAGES)
 
+# Check whether a debug mode should be enabled.
+AC_ARG_WITH([debug],
+    AS_HELP_STRING([--with-debug@<:@=full@:>@],
+      [Enable various amounts of debugging support (full adds a slow memory checker).]),
+    [with_debug=$withval],
+    [with_debug=no])
+
 # Whether the maintainer mode should be enabled.
 MY_MAINTAINER_MODE
 
@@ -1674,11 +1681,6 @@ then
   DEBUG_OPTIMIZE_CXX=""
 fi
 
-AC_ARG_WITH(debug,
-    [  --with-debug            Add debug code
-  --with-debug=full       Add debug code (adds memory checker, very slow)],
-    [with_debug=$withval],
-    [with_debug=no])
 if test "$with_debug" = "yes"
 then
   # Medium debug.


Attachment: [text/bzr-bundle] bzr/davi.arnaut@oracle.com-20101018162710-qudyeyasjclcp4kk.bundle
Thread
bzr commit into mysql-5.1-bugteam branch (davi:3533) Bug#45288Davi Arnaut18 Oct