List:Commits« Previous MessageNext Message »
From:Alexander Barkov Date:October 13 2010 9:00am
Subject:Re: Please review the updated patch for bug51639
View as plain text  
Hi Daogang,

Daogang Qu wrote:
> 2010-10-12 21:28, Alexander Barkov wrote:
>> Hi Daogang,
>>
>> Daogang Qu wrote:
>>> 2010-10-08 18:54, Alexander Barkov wrote:
>>>> Hi Daogang,
>>>>
> [snip]
>>
>>
>>
>> Perhaps this is something related to this change in your patch:
>>
>>    DBUG_RETURN(some_tables_updating &&
>> -              !do_table_inited && !wild_do_table_inited);
>> +              !do_table_array_inited && !wild_do_table_inited);
> Yes. It's the root cause.  Now accent sensitive works fine.
> Please review the updated patch:
> http://lists.mysql.com/commits/120621

The patch is Ok. Thanks for your patience.
Approved.

> 
> Best Regards,
> 
> Daogang
> 
>>  }
>>
>>
>>
>>>
>>> 1.
>>> ./mtr rpl_do_table_filter --mysqld=--log-bin=/var/tmp/masterdg-bin 
>>> --record --manual-gdb --testcase-timeout=1000
>>>
>>> 2. open and rewrite var/tmp/gdbinit.mysqld.2
>>> vi var/tmp/gdbinit.mysqld.2
>>>
>>> Disable the break point in the file as following:
>>> set args --defaults-group-suffix=.1 
>>>
> --defaults-file=/home/daogangqu/mysql/bzrwork/bug34739/mysql-5.1-bugteam/mysql-test/var/my.cnf
> 
>>> --log-output=file --gdb --loose-skip-innodb 
>>> --log-bin=/var/tmp/masterdg-bin --binlog-format=statement --core-file 
>>> --loose-debug-sync-timeout=300
>>> #break mysql_parse
>>> #commands 1
>>> #disable 1
>>> #end
>>> #run
>>>
>>> 3. Run the following command copied from the result of first step.
>>> like this:
>>> libtool --mode execute gdb -cd 
>>> /home/daogangqu/mysql/bzrwork/bug34739/mysql-5.1-bugteam/mysql-test 
>>> -x 
>>>
> /home/daogangqu/mysql/bzrwork/bug34739/mysql-5.1-bugteam/mysql-test/var/tmp/gdbinit.mysqld.1
> 
>>> /home/daogangqu/mysql/bzrwork/bug34739/mysql-5.1-bugteam/sql/mysqld
>>>
>>> (libtool --mode execute) is added extra.
>>>
>>>
>>> 4. Set breakpoint and run it in gdb
>>>
>>> Best Regards,
>>>
>>> Daogang
>>>>
>>>>>
>>>>> Best Regards,
>>>>>
>>>>> Daogang
>>>>>>
>>>>>>
>>>>>>
>>>>>>>
>>>>>>> Best Regards,
>>>>>>>
>>>>>>> Daogang
>>>>>>>
>>>>>>
>>>>>
>>>>
>>>>
>>>
>>
>>
> 

Thread
Please review the updated patch for bug51639Daogang Qu28 Sep
  • Re: Please review the updated patch for bug51639Alexander Barkov30 Sep
    • Re: Please review the updated patch for bug51639Daogang Qu8 Oct
      • Re: Please review the updated patch for bug51639Alexander Barkov8 Oct
        • Re: Please review the updated patch for bug51639Daogang Qu9 Oct
          • Re: Please review the updated patch for bug51639Alexander Barkov12 Oct
          • Re: Please review the updated patch for bug51639Alexander Barkov12 Oct
            • Re: Please review the updated patch for bug51639Daogang Qu13 Oct
              • Re: Please review the updated patch for bug51639Alexander Barkov13 Oct