List:Commits« Previous MessageNext Message »
From:Bjorn Munch Date:October 12 2010 9:08am
Subject:bzr commit into mysql-5.5-mtr branch (bjorn.munch:3098) Bug#40406
View as plain text  
#At file:///home/bm136801/my/pidwait-55/ based on revid:bjorn.munch@stripped

 3098 Bjorn Munch	2010-10-12
      Bug #40406 Please make mtr print better messages when servers fail to start
      Added some more details to warning messages, this should be enough.

    modified:
      mysql-test/lib/mtr_process.pl
=== modified file 'mysql-test/lib/mtr_process.pl'
--- a/mysql-test/lib/mtr_process.pl	2010-06-14 09:31:22 +0000
+++ b/mysql-test/lib/mtr_process.pl	2010-10-12 09:07:15 +0000
@@ -116,18 +116,20 @@ sub sleep_until_file_created ($$$) {
       return 1;
     }
 
+    my $seconds= ($loop * $sleeptime) / 1000;
+
     # Check if it died after the fork() was successful
     if ( defined $proc and ! $proc->wait_one(0) )
     {
-      mtr_warning("Process $proc died");
+      mtr_warning("Process $proc died after mysql-test-run waited $seconds " .
+		  "seconds for it to create a pid file.");
       return 0;
     }
 
     mtr_debug("Sleep $sleeptime milliseconds waiting for $pidfile");
 
     # Print extra message every 60 seconds
-    my $seconds= ($loop * $sleeptime) / 1000;
-    if ( $seconds > 1 and int($seconds * 10) % 600 == 0 )
+    if ( $seconds > 1 && int($seconds * 10) % 600 == 0 && $seconds < $timeout )
     {
       my $left= $timeout - $seconds;
       mtr_warning("Waited $seconds seconds for $pidfile to be created, " .
@@ -138,6 +140,8 @@ sub sleep_until_file_created ($$$) {
 
   }
 
+  mtr_warning("Timeout after mysql-test-run waited $timeout seconds " .
+	      "for the process $proc to create a pid file.");
   return 0;
 }
 


Attachment: [text/bzr-bundle] bzr/bjorn.munch@oracle.com-20101012090715-r41knsnw1u6ub4q0.bundle
Thread
bzr commit into mysql-5.5-mtr branch (bjorn.munch:3098) Bug#40406Bjorn Munch12 Oct