List:Commits« Previous MessageNext Message »
From:Davi Arnaut Date:October 5 2010 12:13pm
Subject:Re: bzr commit into mysql-5.5-bugteam branch (vvaintroub:3092) Bug#55629
View as plain text  
On 10/5/10 7:09 AM, Vladislav Vaintroub wrote:
> #Atfile:///H:/bzr-new/mysql-5.5-bugteam/  based
> onrevid:vvaintroub@stripped
>
>   3092 Vladislav Vaintroub	2010-10-05
>        Bug#55629 5.5.x goes into infinite loop and high cpu after
>        error flushing io cache
>
>        The reason for the error was incorrect return code from
>        my_win_write() in case of error on 64 bit Windows.
>
>        Error should be  indicated by return code
>        (size_t)-1 == 2^64 -1, but due to cast it was
>        (DWORD)-1 = 2^32 -1
>
>        The caller of this function would fail to recognize the error
>        and continue looping.
>
>        Fix is to return correct error code (size_t)-1 in case of error
>        as expected by caller.
>
>        Also minimal cleanup is done : my_win_write() now uses
>        the same parameter checks  as related functions (0 and
>        overflow handling for count parameterr).

parameterr -> parameter

OK to push.
Thread
bzr commit into mysql-5.5-bugteam branch (vvaintroub:3092) Bug#55629Vladislav Vaintroub5 Oct
Re: bzr commit into mysql-5.5-bugteam branch (vvaintroub:3092) Bug#55629Davi Arnaut5 Oct