List:Commits« Previous MessageNext Message »
From:Alexander Nozdrin Date:October 5 2010 9:52am
Subject:Re: bzr commit into mysql-5.5-bugfixing branch (holyfoot:3207) Bug#30025
View as plain text  
Hi Alexey,

thank you for working on this. I'm fine with the patch. However, could
you please change comments to be more readable. Something like:

-------------------------------------------
> Bug#30025 Mysqld prints out warnings/errors being run with --no-defaults --help
> now do no initializations for the --help.
> Do it for --verbose --help though.

Bug#30025 (Mysqld prints out warnings/errors being run with 
--no-defaults --help).

The problem was that server initialization was done before help
message was shown. Thus, even if the server was started only
to print out brief help information, initialization warnings/errors
would pollute the output.

A fix is to print out brief help message right after command-line
options are processed.

Full help message (--help --verbose) is still printed after
the server initialization, because it contains values of server
variables, which are set during initialization phase.
-------------------------------------------

/*
   Print out brief help message here to avoid
   unnecessary initialization.
*/

> +#ifndef EMBEDDED_LIBRARY
> +  if (opt_help && !opt_verbose)
> +    unireg_abort(0);
> +#endif /*!EMBEDDED_LIBRARY*/
> +
> +

Why do you need two blank lines here?

I think the patch can be pushed after fixing the comments.

Thank you!
Thread
Re: bzr commit into mysql-5.5-bugfixing branch (holyfoot:3207) Bug#30025Alexander Nozdrin5 Oct