From: Date: September 15 2006 2:01am
Subject: bk commit into 5.0 tree (ted:1.2265) BUG#21011
List-Archive: http://lists.mysql.com/commits/11977
X-Bug: 21011
Message-Id: <200609150001.k8F01qCR032349@ted.mysql.internal>

Below is the list of changes that have just been committed into a local
5.0 repository of ted. When ted does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet@stripped, 2006-09-15 04:01:47+04:00, ted@stripped +1 -0
  Bug#21011 The [client] group header was overwritten by "password" option in upgrade_defaults file which confused mysqlcheck thus used to prevent the whole thing from running correctly when the "--password=" option is specified on mysql_upgrade command line with no corresponding "--user=" option

  client/mysql_upgrade.c@stripped, 2006-09-15 04:01:45+04:00, ted@stripped +1 -1
    The "password" option should be issued after group header to upgrade_defaults file whenever it is used

# This is a BitKeeper patch.  What follows are the unified diffs for the
# set of deltas contained in the patch.  The rest of the patch, the part
# that BitKeeper cares about, is below these diffs.
# User:	ted
# Host:	ted.mysql.internal
# Root:	/home/ted/src/mysql/mysql-5.0-5.1-gca

--- 1.6/client/mysql_upgrade.c	2006-09-15 04:01:53 +04:00
+++ 1.7/client/mysql_upgrade.c	2006-09-15 04:01:53 +04:00
@@ -200,7 +200,7 @@
   }
   buffer_end= strnmov(buffer, "\n[client]", sizeof(buffer));
   if (opt_password)
-    buffer_end= strxnmov(buffer, sizeof(buffer),
+    buffer_end= strxnmov(buffer_end, sizeof(buffer),
                          "\npassword=", opt_password, NullS);
   error= my_write(defaults_file, buffer, (int) (buffer_end - buffer),
                   MYF(MY_WME | MY_FNABP));