#At file:///home/msvensson/mysql/7.0/ based on revid:jonas@stripped
3797 Magnus Blåudd 2010-09-29
Bug#57087 ndb(mt)d printout about "Failed to create directory" during restart
- Use ignore_existing flag for NdbDir::create so it don't print the error message
when directory already exists.
- Add ending new line to the error messages
modified:
storage/ndb/src/common/portlib/NdbDir.cpp
storage/ndb/src/kernel/blocks/ndbfs/Ndbfs.cpp
=== modified file 'storage/ndb/src/common/portlib/NdbDir.cpp'
--- a/storage/ndb/src/common/portlib/NdbDir.cpp 2010-09-23 09:10:53 +0000
+++ b/storage/ndb/src/common/portlib/NdbDir.cpp 2010-09-29 07:54:14 +0000
@@ -209,7 +209,7 @@ NdbDir::create(const char *dir, mode_t m
return true;
fprintf(stderr,
- "Failed to create directory '%s', error: %d",
+ "Failed to create directory '%s', error: %d\n",
dir, GetLastError());
return false;
}
@@ -220,7 +220,7 @@ NdbDir::create(const char *dir, mode_t m
return true;
fprintf(stderr,
- "Failed to create directory '%s', error: %d",
+ "Failed to create directory '%s', error: %d\n",
dir, errno);
return false;
}
=== modified file 'storage/ndb/src/kernel/blocks/ndbfs/Ndbfs.cpp'
--- a/storage/ndb/src/kernel/blocks/ndbfs/Ndbfs.cpp 2010-09-23 09:36:19 +0000
+++ b/storage/ndb/src/kernel/blocks/ndbfs/Ndbfs.cpp 2010-09-29 07:54:14 +0000
@@ -137,7 +137,8 @@ bool
do_mkdir(const char * path)
{
return NdbDir::create(path,
- NdbDir::u_rwx() | NdbDir::g_r() | NdbDir::g_x());
+ NdbDir::u_rwx() | NdbDir::g_r() | NdbDir::g_x(),
+ true /* ignore_existing */);
}
static
Attachment: [text/bzr-bundle] bzr/magnus.blaudd@sun.com-20100929075414-fal7s8ej53qsetul.bundle
| Thread |
|---|
| • bzr commit into mysql-5.1-telco-7.0 branch (magnus.blaudd:3797) Bug#57087 | Magnus Blåudd | 29 Sep |