List:Commits« Previous MessageNext Message »
From:Martin Hansson Date:September 22 2010 12:58pm
Subject:Re: bzr commit into mysql-5.1-bugteam branch (martin.hansson:3514)
Bug#56423
View as plain text  
>
>
> I wrote in previous email it's better to use
> HA_PARTIAL_COLUMN_READ check,
> see suggested patch(attachment). 
It seems you are right about this magic flag. But it bothers me
that this isn't documented anywhere. Above the #define would be the 
logical place.

Also, I found this code copy-pasted before every time we call compare 
record:

  ...
    can_compare_record= (!(table->file->ha_table_flags() &
                           HA_PARTIAL_COLUMN_READ) ||
                         bitmap_is_subset(table->write_set,
                                          table->read_set));

...
      if (!can_compare_record || compare_record(table))
...

Now that compare_record can always be used I suggest moving this code 
into that function. What do you think?

/Martin
Thread
bzr commit into mysql-5.1-bugteam branch (martin.hansson:3514) Bug#56423Martin Hansson21 Sep
Re: bzr commit into mysql-5.1-bugteam branch (martin.hansson:3514)Bug#56423Martin Hansson22 Sep