List:Commits« Previous MessageNext Message »
From:Tor Didriksen Date:September 16 2010 12:10pm
Subject:Re: bzr commit into mysql-next-mr-opt-team branch (tor.didriksen:3215)
WL#1393
View as plain text  
On 2010-09-16 11:46, Konstantin Osipov wrote:
> * Tor Didriksen<tor.didriksen@stripped>  [10/09/16 13:42]:
>    
>>>> +Bounded_queue::Bounded_queue()
>>>> +{
>>>> +  memset(&m_queue, 0, sizeof(m_queue));
>>>> +}
>>>>          
>>> Why not make it a generic C++ template wrapper around mysys queue?
>>>
>>> Could be done in a separate pre-requisite patch, I would love
>>> to review it (but I don't think there will be shortage of
>>> reviewers from the optimizer team).
>>>        
>> I will consider it, if we agree to remove -fno-implicit-templates
>>      
> Why is this related? We have templates for lists and they work
> just fine with -fno-implicit-templates.
>
>
>    
you're right I guess.
it's just not intuitive to write generic code, and then maintain 
explicit instantiations
(two places I guess, in filesort.cc and in the unit test for Bounded_queue()

-- didrik

Thread
bzr commit into mysql-next-mr-opt-team branch (tor.didriksen:3215) WL#1393Tor Didriksen7 Sep
  • Re: bzr commit into mysql-next-mr-opt-team branch (tor.didriksen:3215)WL#1393Evgeny Potemkin7 Sep
    • Re: bzr commit into mysql-next-mr-opt-team branch (tor.didriksen:3215)WL#1393Tor Didriksen7 Sep
  • Re: bzr commit into mysql-next-mr-opt-team branch (tor.didriksen:3215)WL#1393Konstantin Osipov16 Sep
    • Re: bzr commit into mysql-next-mr-opt-team branch (tor.didriksen:3215)WL#1393Tor Didriksen16 Sep
      • Re: bzr commit into mysql-next-mr-opt-team branch (tor.didriksen:3215)WL#1393Konstantin Osipov16 Sep
        • Re: bzr commit into mysql-next-mr-opt-team branch (tor.didriksen:3215)WL#1393Tor Didriksen16 Sep
      • Re: bzr commit into mysql-next-mr-opt-team branch (tor.didriksen:3215)WL#1393Konstantin Osipov16 Sep
        • Re: bzr commit into mysql-next-mr-opt-team branch (tor.didriksen:3215)WL#1393Tor Didriksen16 Sep
          • Re: bzr commit into mysql-next-mr-opt-team branch (tor.didriksen:3215)WL#1393Konstantin Osipov16 Sep
            • Re: bzr commit into mysql-next-mr-opt-team branch (tor.didriksen:3215)WL#1393Tor Didriksen17 Sep