Hi Libing,
Excellent questions and comments.
I will try to figure them out and commit a new patch.
Cheers.
On 09/10/2010 05:00 AM, Libing Song wrote:
> Hi Alfranio,
> Nice work!
>
> Please find my review comments below.
> The patch is ok for this bug, but two questions need to be clarify.
>
> STATUS
> ------
>
> Not Approved.
>
> REQUIRED CHANGES
> ----------------
> RE1. We have to caches now, statement's cache and transactional cache.
> Should binlog_cache_use be increased twice if both satement's cache
> and transactional cache are used.
>
> I suppose you think so. As this, it should be documented. Could you
> please add comments to mark that it should be documented.
>
> RE2. Should binlog_cache_use be increase on the following case?
>
> BEGIN;
> INSERT INTO t1 VALUES(1);
> ROLLBACK
>
> I think it should be record too.
>
> REQUESTS
> --------
>
>
> SUGGESTIONS
> -----------
>
> DETAILS
