List:Commits« Previous MessageNext Message »
From:Olav Sandstaa Date:September 9 2010 1:29pm
Subject:Re: bzr commit into mysql-5.5-bugfixing branch (olav:3204) Bug#54478
View as plain text  
Hi Sergei,

On 09/ 8/10 08:08 PM, Sergei Golubchik wrote:
> And how about changing DbugVfprintf() function to use my_vsnprintf()
> which has the NULL check built it ?
>
> DbugVfprintf was introduced for the sole purpose of using my_vsnprintf
> in dbug - but later changed to use vsnprintf() with the comment
> /* Do not use my_vsnprintf, it does not support "%g". */
>
> Now guess what - in 5.5 my_vsnprintf() supports %g as far as I can see,
> so dbug can safely use my_vsnprintf again. And pass NULL for %s, and
> use %p format specifier, and so on.
>    

Thanks for your suggestion. I have committed a new patch for this change:

   http://lists.mysql.com/commits/117878

Tor discovered that %i was not supported in my_vsnprintf() and was used 
a few places in our code. So this patch also extends my_vsnprintf() to 
support %i in the format string.

Best regards,
Olav
Thread
bzr commit into mysql-5.5-bugfixing branch (olav:3204) Bug#54478Olav Sandstaa8 Sep
  • Re: bzr commit into mysql-5.5-bugfixing branch (olav:3204) Bug#54478Tor Didriksen8 Sep
    • Re: bzr commit into mysql-5.5-bugfixing branch (olav:3204)Bug#54478Sergei Golubchik8 Sep
      • Re: bzr commit into mysql-5.5-bugfixing branch (olav:3204) Bug#54478Tor Didriksen9 Sep
      • Re: bzr commit into mysql-5.5-bugfixing branch (olav:3204) Bug#54478Olav Sandstaa9 Sep
        • Re: bzr commit into mysql-5.5-bugfixing branch (olav:3204)Bug#54478Sergei Golubchik9 Sep
          • Re: bzr commit into mysql-5.5-bugfixing branch (olav:3204) Bug#54478Olav Sandstaa10 Sep