List:Commits« Previous MessageNext Message »
From:Alfranio Correia Date:September 9 2010 10:55am
Subject:Re: bzr commit into mysql-trunk-bugfixing branch (alfranio.correia:3258)
WL#5485
View as plain text  
Hi Libing,

Thanks for the review.
I agree with you.

I will wait for Daogang's feedback and right after change everything you requested and
suggested.

Cheers.

On 09/09/2010 11:35 AM, Libing Song wrote:
> Hi Alfranio,
>
> Nice work!
> Please find my review comments below.
>
> STATUS
> ------
>
>    Not Approved.
>
> REQUIRED CHANGES
> ----------------
> RE1.
> +# B Sn N Cn/Rn C/R
> It should be
> +# B T Sn N Cn/Rn C/R
>
> Please check all other comments.
>
> RE2. Could you please comment(In both WL and patch) in which sequence
> the savepoints is rolled back.
> Example:
> B T Sn N Sn T N Rn Rn C
> means: B T S1 N S2 T N R2 R1 C.
> It rolls back S2 first and then rolls back S1.
>
> RE3. You forgot the test for 'B T Sn TEMP Cn/Rn C/R'
>
> RE4. Could you please comment(In both WL and patch) the expect behavior
> for each test case?
>
>
> REQUESTS
> --------
> Nothing.
>
>
> SUGGESTIONS
> -----------
> SU1.
> I think 'B T S1 N S2 T N R2 R1 C' is more clear.
> So I suggest to use it.

Thread
bzr commit into mysql-trunk-bugfixing branch (alfranio.correia:3258) WL#5485Alfranio Correia2 Sep
  • Re: bzr commit into mysql-trunk-bugfixing branch(alfranio.correia:3258) WL#5485Libing Song9 Sep
    • Re: bzr commit into mysql-trunk-bugfixing branch (alfranio.correia:3258)WL#5485Alfranio Correia9 Sep