List:Commits« Previous MessageNext Message »
From:Sergei Golubchik Date:September 8 2010 6:08pm
Subject:Re: bzr commit into mysql-5.5-bugfixing branch (olav:3204)
Bug#54478
View as plain text  
Hi, Tor!

On Sep 08, Tor Didriksen wrote:
> how about
> static inline const char* sting_or_null(const char *str) { return str ? str
> : "(null)"; }

And how about changing DbugVfprintf() function to use my_vsnprintf()
which has the NULL check built it ?

DbugVfprintf was introduced for the sole purpose of using my_vsnprintf
in dbug - but later changed to use vsnprintf() with the comment
/* Do not use my_vsnprintf, it does not support "%g". */

Now guess what - in 5.5 my_vsnprintf() supports %g as far as I can see,
so dbug can safely use my_vsnprintf again. And pass NULL for %s, and
use %p format specifier, and so on.
 
Regards,
Sergei
Thread
bzr commit into mysql-5.5-bugfixing branch (olav:3204) Bug#54478Olav Sandstaa8 Sep
  • Re: bzr commit into mysql-5.5-bugfixing branch (olav:3204) Bug#54478Tor Didriksen8 Sep
    • Re: bzr commit into mysql-5.5-bugfixing branch (olav:3204)Bug#54478Sergei Golubchik8 Sep
      • Re: bzr commit into mysql-5.5-bugfixing branch (olav:3204) Bug#54478Tor Didriksen9 Sep
      • Re: bzr commit into mysql-5.5-bugfixing branch (olav:3204) Bug#54478Olav Sandstaa9 Sep
        • Re: bzr commit into mysql-5.5-bugfixing branch (olav:3204)Bug#54478Sergei Golubchik9 Sep
          • Re: bzr commit into mysql-5.5-bugfixing branch (olav:3204) Bug#54478Olav Sandstaa10 Sep