From: Jon Olav Hauglid
Date: September 8 2010 8:31am
Subject: bzr commit into mysql-5.5-runtime branch (jon.hauglid:3134) Bug#56595
List-Archive: http://lists.mysql.com/commits/117757
X-Bug: 56595
Message-Id: <201009080832.o888Wn3O032527@rcsinet15.oracle.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============3497030395548612653=="

--===============3497030395548612653==
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

#At file:///export/home/x/mysql-5.5-runtime-bug56595/ based on revid:jon.hauglid@stripped

 3134 Jon Olav Hauglid	2010-09-08
      Bug #56595 RENAME TABLE causes assert on OS X
      
      The problem was that RENAME TABLE caused an assert if the system variable
      lower_case_table_names was 2 (default on Mac OS X) and the old table name
      was given in upper case. This was also seen in the lowercase_table2.test.
      
      The assert checks that an exclusive metadata lock is held by the connection
      trying to do RENAME TABLE - specificially during updates of triggers.
      The assert was triggered since the check is case sensitive and the lock
      was held on the lower case table name.
      
      This patch fixes the problem by making sure the lower case version of the
      table name is used for Table_triggers_list::change_table_name() and thus
      also the metadata lock check, similar to what is already done for
      ALTER TABLE ... RENAME.
      
      No test case added since this problem is already covered by 
      lowercase_table2.test

    modified:
      sql/sql_rename.cc
=== modified file 'sql/sql_rename.cc'
--- a/sql/sql_rename.cc	2010-08-10 11:16:44 +0000
+++ b/sql/sql_rename.cc	2010-09-08 08:31:27 +0000
@@ -284,7 +284,7 @@ do_rename(THD *thd, TABLE_LIST *ren_tabl
                                      new_db, new_alias, 0)))
         {
           if ((rc= Table_triggers_list::change_table_name(thd, ren_table->db,
-                                                          old_alias,
+                                                          ren_table->table_name,
                                                           new_db,
                                                           new_alias)))
           {


--===============3497030395548612653==
MIME-Version: 1.0
Content-Type: text/bzr-bundle; charset="us-ascii";
	name="bzr/jon.hauglid@stripped"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

# Bazaar merge directive format 2 (Bazaar 0.90)
# revision_id: jon.hauglid@stripped
# target_branch: file:///export/home/x/mysql-5.5-runtime-bug56595/
# testament_sha1: a3e06e246989056429130b189d682b3a4b0e0b49
# timestamp: 2010-09-08 10:31:30 +0200
# source_branch: file:///export/home/x/mysql-5.5-bugfixing/
# base_revision_id: jon.hauglid@stripped\
#   pst8wmfw6hcklpyd
# 
# Begin bundle
IyBCYXphYXIgcmV2aXNpb24gYnVuZGxlIHY0CiMKQlpoOTFBWSZTWSfLUq0AAcvfgEAQWGf/93JX
nEC////wUAUal3vXvOTkm9pEPbvWEoRMmkyaaMRPUyNMkek0eKHkQNPJA0ImEZGFEyaMjQGmQNGg
AAamJimjUyNTQe1IANAAA09TQAkShoASntE2KTynqaNGj1AAADQSSCE0wEap5Mp4nqn6myptTIye
kAAWCsaSuwmXt7uF2L4fGe8rRMhiQA+Y7lImh+Oeh4lq/WY9Z8m47ed6qpT+UsfHKybKXuHevSRQ
umi3PX91MHcjRYlUk0Apqa6yaMoVhqKdLiFaYlW61wqi4sRg41AoVFAYPJHEsjKpEYmfIw6N6KEr
BxjGbTQnRmVKrFVIuriw1Ur/HR3aTbwGUTXSp47vN+E1BWIexMZbNpjUTi1t00zOVVmfjh7Oq22g
SwSO0lF89KuKFixvtmIc4TEBwwhyQw4w4CtL/FBHcgZBLpTKeyD3qgC44hgIO7V5RHQzwguxWwE5
4bfhW2QqVoo4aYtqMpjTAnluYd/hRs8HGy0yKWESH5ZUSWbDGAto0UxmICli/R3jgDLMQMLleh0i
KgHK2OC5AmUQvdZGJo6NTjBbnMVQzs4nQvIRXpYmGPgXpV1ZjUF7uXhSVBTEsdkskoxmcXQjSj7y
goPdNPdIoJxMaOdB5rdvqwt8ZriSgnMptvqoEGB24KIDDPcmgxiximNYbDA5IHaigQDpZJxPEKhu
EAq+IuCugFJt8JXGY51TebQWNkgyLFXkghFeRfiul5ZEd5em/bMiHUMXQJ0ZVP2HG/+nRFFh+gll
h3hJB0goZGUOooYleCpwzXVI6ssE70gRihwzw34Hp0kQar+tKRA9ldHax7bJQ4UEq1XCNLyRld01
1o8vEVQEoUzJuRKzv3BI6SlHod+vf55/kK0/ZcBNaiHFJbrU7AmklMFtWCGg92NnNNJv5/U+PCq4
un2PpRtF5azK7UjPRD/ZEQnnJoqalFYadeVJ2c/Mu0SqKbAiQEqzuYvPW31eQKywlvdEtv525vCF
kXohBOUWbt5M6Qiw5k4FYw2eok+XhLDPRDewAytCGnLGIlrxrKjmHgk0HDm6VnubrW+yfEdv2heb
Te5tNgXshNczUyx1snVOdbIgKXR5Ovk5k1cHB6khxkbcVorbAyLnxzfsDAnLW/nK008HBzxG2mS7
pLYKPKiahXl6skCwtxXUD4HX50jgpvaNA3tkrSed9go3prh4Sl4Zc+nRQkRVdyK61rYpLKlM8wVN
0m6ctcmiZGgMhm5hbCqR3Gt0csaA+Z4DOr1pXFOwMYBP9jeFQdhW8ILHq87++DBOkOcMyV4Kmndk
7eh43FbiAR5FlDZCrCtIn9S0BYwtroDZJ58asC2usswSiVbVBcQTDSUXG0cJxOUAwo7HATVTbsC2
xXtVNNYZ5afVxXWtyfgW8FZB3xD/KQ1bxlSXnekXBC6QspXooMMV7zHRtPdQUW2c95NIlSquCuXc
LW5FdxatRlIyZJc4L5yDpxVKMnFcEZdmErROBabYKxuAGzFBapaATGZEZg+NDQy3EmqEQJSosiD/
N9DVSKfSFk0aFw1mebT0bXuLbQMsRXoyRBwo0jmEggmsgtO8IGZDoBtOAdaNgJz32u40KpFURO1+
FdeQ8M2kkVBBGLGzSZI4Yc+6sE2LEPgIh28xZ11I8LiV5VVlAsLSoUBjawgm4mvMrRSsqteMOFmc
k+pLU8U053aTif8XckU4UJAny1Kt


--===============3497030395548612653==--