Hi Matthias
On 7/29/10 1:48 PM, Matthias Leich wrote:
> #At file:///work2/repo/mysql-next-mr-wl4674-1/ based on
> revid:marc.alff@stripped
>
> 3165 Matthias Leich 2010-07-29
> Improved and additional tests for
> WL#4674 PERFORMANCE_SCHEMA Setup For Actors
> Attention:
> schema_lc1.result and schema_lc2.result are "guesses" because I couldn't
> check them within my environment.
That's ok, results will be adjusted if needed.
Thanks for the warning
> @ mysql-test/suite/perfschema/include/schema.inc
> - make test more robust against databases to be added in future
> - add the missing show create
> @ mysql-test/suite/perfschema/t/schema_lc0.test
> Improved comment
> @ mysql-test/suite/perfschema/t/schema_lc1.test
> Improved comment
> @ mysql-test/suite/perfschema/t/schema_lc2.test
> Improved comment
> @ mysql-test/suite/perfschema/t/setup_actors.test
> - Improved comments
> - add several subtests for properties mentioned within the WL
> - minor changes in formatting which improve the synchronization in graphical
> diff tools
> @ mysql-test/suite/perfschema/t/threads_innodb.test
> Show InnoDB related content in performance_schema.THREADS
> @ mysql-test/suite/perfschema/t/threads_insert_delayed.test
> Show the insert delayed thread in performance_schema.THREADS
> @ mysql-test/suite/perfschema/t/threads_mysql.test
> Show MySQL server related content in performance_schema.THREADS
> - event scheduler, event worker, signal handler, current connection, main
> - parent child relationship of threads
> but no storage engine related stuff.
>
> added:
> mysql-test/suite/perfschema/r/threads_events.result
> mysql-test/suite/perfschema/r/threads_innodb.result
> mysql-test/suite/perfschema/r/threads_insert_delayed.result
> mysql-test/suite/perfschema/r/threads_mysql.result
> mysql-test/suite/perfschema/t/threads_innodb.test
> mysql-test/suite/perfschema/t/threads_insert_delayed.test
> mysql-test/suite/perfschema/t/threads_mysql-master.opt
> mysql-test/suite/perfschema/t/threads_mysql.test
> modified:
> mysql-test/suite/perfschema/include/schema.inc
> mysql-test/suite/perfschema/r/schema_lc0.result
> mysql-test/suite/perfschema/r/schema_lc1.result
> mysql-test/suite/perfschema/r/schema_lc2.result
> mysql-test/suite/perfschema/r/setup_actors.result
> mysql-test/suite/perfschema/t/schema_lc0.test
> mysql-test/suite/perfschema/t/schema_lc1.test
> mysql-test/suite/perfschema/t/schema_lc2.test
> mysql-test/suite/perfschema/t/setup_actors.test
All ok.
I see we use different formatting preferences for SQL in tests scripts,
but it's not worth arguing about.
Thanks for all the new tests and the cleanup / improvements on existing
ones.
Ok to push into mysql-next-mr-wl4674
Regards,
-- Marc