Hello Jon Olav!
* Jon Olav Hauglid <jon.hauglid@stripped> [10/08/19 13:19]:
> #At file:///export/home/x/mysql-5.5-runtime-bug56085/ based on
> revid:jon.hauglid@stripped
>
> 3113 Jon Olav Hauglid 2010-08-19
> Bug #56085 Embedded server tests fails with assert in
> check_if_table_exists()
>
> This assert was triggered when the server tried to load plugins
> while running in embedded server mode. In embedded server mode,
> check_if_table_exists() was used to check if mysql.plugin existed
> so that ER_NO_SUCH_TABLE could be silently ignored.
> The problem was that this check was done without acquiring a metadata
> lock on mysql.plugin first. This triggered the assert.
>
> This patch fixes the problem by removing the call to
> check_if_table_exists() from plugin_load(). Instead an error handler
> which traps ER_NO_SUCH_TABLE is installed before trying to open
> mysql.plugin when running in embedded server mode.
>
> No test coverage added since this assert was triggered by
> existing tests running in embedded server mode.
...
> @ sql/sql_plugin.cc
> Removed call to check_if_table_exists() used to check for mysql.plugin
> in plugin_load() for embedded server. Instead installs error handler
^^^^^^^
A typo? install (without s)
> which traps ER_NO_SUCH_TABLE during open_and_lock_tables().
>
IMO, this patch is OK to push.
Thank you!
--
Dmitry Lenev, Software Developer
Oracle Development SPB/MySQL, www.mysql.com
Are you MySQL certified? http://www.mysql.com/certification
