From: Martin Hansson Date: August 12 2010 4:08pm Subject: Re: bzr commit into mysql-5.1-bugteam branch (Georgi.Kodinov:3479) Bug#55580 List-Archive: http://lists.mysql.com/commits/115619 Message-Id: <4C641C73.8040407@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Hi, patch approved, just one minor comment. Georgi Kodinov skrev 2010-08-12 13.46: > ... > +SELECT * FROM t1 GROUP BY POLYGON((SELECT a FROM t2 LIMIT 1 FOR UPDATE), t1.a); > I would use a different function that POLYGON here. Otherwise people will get surprised that such a limited-application function is needed. You can provoke that crash using SELECT * FROM t1 GROUP BY (SELECT a FROM t2 LIMIT 1 FOR UPDATE) + t1.a; otherwise, great patch. Best Regards Martin