| List: | Commits | « Previous MessageNext Message » | |
| From: | Jorgen Loland | Date: | August 9 2010 9:26am |
| Subject: | Re: bzr commit into mysql-next-mr-opt-backporting branch (guilhem:3208) Bug#54437 | ||
| View as plain text | |||
Guilhem, I am convinced by your patch and your explanation why my query fails. The patch is approved with one minor suggestion: + JOIN_TAB *first_unmatched= join_tab->first_unmatched; + if ((first_unmatched= first_unmatched->first_upper) && + first_unmatched->last_inner != join_tab) + first_unmatched= 0; + join_tab->first_unmatched= first_unmatched; Please add a comment to this code block. Btw, there is a similar block in evaluate_join_record that is commented. (Sorry for not posting appropriately to the thread - some email disappeared when migrating to new mail server) Jørgen
