List:Commits« Previous MessageNext Message »
From:Magnus Blåudd Date:August 5 2010 8:58am
Subject:bzr push into mysql-5.1-telco-7.0 branch (magnus.blaudd:3666 to 3667) WL#5508
View as plain text  
 3667 Magnus Blåudd	2010-08-05
      WL#5508 SEAGULL: Move NDB version configuration down into storage/ndb
       - Improve comments and group defines together

    modified:
      storage/ndb/include/ndb_version.h.in
      storage/ndb/ndb_configure.m4
 3666 Magnus Blåudd	2010-08-04
      WL#5508 SEAGULL: Move NDB version configuration down into storage/ndb
       - Calculate the NDB_MYSQL_VERSION_XX variables from MYSQL_VERSION_ID
         thus removing the need for our build systems to extract it.
       - Remove automake and cmake code to extract NDB_MYSQL_VERSION_XX
       - Add test that NDB_MYSQL_VERSION_XX maps backto MYSQL_VERSION_ID
       - Remove NDB_MYSQL_VERSION_XX from my_config.h/config.h

    modified:
      storage/ndb/include/CMakeLists.txt
      storage/ndb/include/ndb_version.h.in
      storage/ndb/ndb_configure.m4
      storage/ndb/src/common/util/version.cpp
=== modified file 'storage/ndb/include/ndb_version.h.in'
--- a/storage/ndb/include/ndb_version.h.in	2010-08-04 14:00:24 +0000
+++ b/storage/ndb/include/ndb_version.h.in	2010-08-05 08:12:31 +0000
@@ -22,22 +22,38 @@
 #include <ndb_types.h>
 #include <mysql_version.h>
 
-/* NDB version numbers and status */
+/*
+  Creates a composite version number from major, minor and build
+  ex: NDB_MAKE_VERSION(5,1,47) => 0x00050147
+*/
+#define NDB_MAKE_VERSION(A,B,C) (((A) << 16) | ((B) << 8)  | ((C) << 0))
+
+/* NDB version numbers and status  */
 #define NDB_VERSION_MAJOR @NDB_VERSION_MAJOR@
 #define NDB_VERSION_MINOR @NDB_VERSION_MINOR@
 #define NDB_VERSION_BUILD @NDB_VERSION_BUILD@
 #define NDB_VERSION_STATUS "@NDB_VERSION_STATUS@"
 
-/* MySQL Server version numbers extracted from MYSQL_VERSION_ID */
+/* Composite version number for NDB */
+#define NDB_VERSION_D \
+  NDB_MAKE_VERSION(NDB_VERSION_MAJOR, NDB_VERSION_MINOR, NDB_VERSION_BUILD)
+
+/*
+  The version number of the MySQL Server that NDB is built
+  with. Extracted from MYSQL_VERSION_ID
+*/
 #define NDB_MYSQL_VERSION_MAJOR ((MYSQL_VERSION_ID / 10000) % 100)
 #define NDB_MYSQL_VERSION_MINOR ((MYSQL_VERSION_ID /100) % 100)
 #define NDB_MYSQL_VERSION_BUILD (MYSQL_VERSION_ID % 100)
 
-#define NDB_MAKE_VERSION(A,B,C) (((A) << 16) | ((B) << 8)  | ((C) << 0))
+/* Composite version number for MYSQL Server */
+#define NDB_MYSQL_VERSION_D \
+  NDB_MAKE_VERSION(NDB_MYSQL_VERSION_MAJOR, \
+                   NDB_MYSQL_VERSION_MINOR, \
+                   NDB_MYSQL_VERSION_BUILD)
 
-#define NDB_MYSQL_VERSION_D NDB_MAKE_VERSION(NDB_MYSQL_VERSION_MAJOR, NDB_MYSQL_VERSION_MINOR, NDB_MYSQL_VERSION_BUILD)
-#define NDB_VERSION_D NDB_MAKE_VERSION(NDB_VERSION_MAJOR, NDB_VERSION_MINOR, NDB_VERSION_BUILD)
 #define NDB_VERSION_STRING_BUF_SZ 100
+
 #ifdef __cplusplus
 extern "C" {
 #endif

=== modified file 'storage/ndb/ndb_configure.m4'
--- a/storage/ndb/ndb_configure.m4	2010-08-04 14:00:24 +0000
+++ b/storage/ndb/ndb_configure.m4	2010-08-05 08:12:31 +0000
@@ -1,4 +1,5 @@
-# The version number of NDB
+# The NDB version number and status.
+# Should be updated when creating a new NDB version
 NDB_VERSION_MAJOR=7
 NDB_VERSION_MINOR=0
 NDB_VERSION_BUILD=17

Attachment: [text/bzr-bundle] bzr/magnus.blaudd@sun.com-20100805081231-u48tf5zlk1l7nnjs.bundle
Thread
bzr push into mysql-5.1-telco-7.0 branch (magnus.blaudd:3666 to 3667) WL#5508Magnus Blåudd5 Aug