List:Commits« Previous MessageNext Message »
From:Davi Arnaut Date:July 30 2010 2:32pm
Subject:Re: bzr commit into mysql-trunk-runtime branch (alik:3158) Bug#5889
Bug#9857 Bug#23032 Bug#36185
View as plain text  
Hi Alik,

On 7/30/10 8:35 AM, Alexander Nozdrin wrote:
> #At file:///mnt/raid/alik/MySQL/bzr/00/bug23032/mysql-trunk-bugfixing-bug23032/ based
> on revid:alik@stripped
>
>   3158 Alexander Nozdrin	2010-07-30
>        This patch fixes the following bugs:
>          - Bug#5889: Exit handler for a warning doesn't hide the warning in
>            trigger
>          - Bug#9857: Stored procedures: handler for sqlwarning ignored
>          - Bug#23032: Handlers declared in a SP do not handle warnings generated
>            in sub-SP
>          - Bug#36185: Incorrect precedence for warning and exception handlers
>

Good work, OK to push. Some minor comments below.

[..]

>
> +  DBUG_EXECUTE_IF("bug23032_emit_warning",
> +                  push_warning(thd, MYSQL_ERROR::WARN_LEVEL_WARN,
> +                               ER_WARN_HOSTNAME_WONT_WORK,
> +                               ER(ER_WARN_HOSTNAME_WONT_WORK)););
> +

I suggest using ER_UNKNOWN_ERROR with a message "this is a test".

>     result.set_spvar_list(vars);
>
>     /* Attempt to fetch one row */
>

Regards,

Davi
Thread
bzr commit into mysql-trunk-runtime branch (alik:3158) Bug#5889Bug#9857 Bug#23032 Bug#36185Alexander Nozdrin30 Jul
  • Re: bzr commit into mysql-trunk-runtime branch (alik:3158) Bug#5889Bug#9857 Bug#23032 Bug#36185Davi Arnaut30 Jul