List:Commits« Previous MessageNext Message »
From:Jon Olav Hauglid Date:July 20 2010 11:13am
Subject:Re: bzr commit into mysql-trunk-bugfixing branch (davi:3134) WL#5498
View as plain text  
On 07/20/2010 04:33 AM, Davi Arnaut wrote:
> # At a local mysql-trunk-bugfixing repository of davi
>
>   3134 Davi Arnaut	2010-07-19
>        WL#5498: Remove dead and unused source code
>
>        Remove the ancient and dead raid code. By now, even the server side
>        has been removed.

See comments below.

>      removed:
>        mysql-test/r/raid.result
>      modified:
>        extra/replace.c
>        extra/resolve_stack_dump.c
>        include/my_global.h
>        include/my_nosys.h
>        include/my_sys.h
>        include/myisam.h
>        include/mysql_embed.h
>        libmysql/Makefile.am
>        libmysql_r/Makefile.am
>        mysql-test/t/show_check.test
>        mysys/mf_iocache.c
>        mysys/mf_iocache2.c
>        storage/myisam/mi_check.c
>        storage/myisam/mi_create.c
>        storage/myisam/mi_delete_table.c
>        storage/myisam/mi_open.c
>        storage/myisam/mi_rename.c
>        storage/myisam/myisamchk.c
>        storage/myisam/myisamdef.h

Remaining raid references I've found:
- ER_NO_RAID_COMPILED - mysqld_error.h, mysqld_ername.h
- mysql_rm_known_files() - sql_db.cc
- 4 RAID commands in client/mysql.cc

Have you considered these?

> === modified file 'storage/myisam/myisamdef.h'
> --- a/storage/myisam/myisamdef.h	2010-07-15 11:16:06 +0000
> +++ b/storage/myisam/myisamdef.h	2010-07-20 02:33:33 +0000
> @@ -26,10 +26,6 @@
>   #endif
>   #include<mysql/psi/mysql_file.h>
>
> -#if defined(my_write)&&  !defined(MAP_TO_USE_RAID)
> -#undef my_write				/* undef map from my_nosys; We need test-if-disk full */
> -#endif
> -
>   typedef struct st_mi_status_info
>   {
>     ha_rows records;			/* Rows in table */

Not sure I get this change. Could you explain?

Otherwise looks ok.

--- Jon Olav
Thread
bzr commit into mysql-trunk-bugfixing branch (davi:3134) WL#5498Davi Arnaut20 Jul
Re: bzr commit into mysql-trunk-bugfixing branch (davi:3134) WL#5498Jon Olav Hauglid20 Jul