List:Commits« Previous MessageNext Message »
From:Jon Olav Hauglid Date:July 20 2010 8:33am
Subject:Re: bzr commit into mysql-trunk-bugfixing branch (davi:3131) WL#5498
View as plain text  
On 07/20/2010 04:23 AM, Davi Arnaut wrote:
> # At a local mysql-trunk-bugfixing repository of davi
>
>   3131 Davi Arnaut	2010-07-19
>        WL#5498: Remove dead and unused source code
>
>        Remove code that has been disabled for a long time.

This patch looks ok.

There's still remaining NOT_USED/NOT_USED_YET blocks in:
storage/myisam/myisamdef.h
storage/heap/hp_test2.c
storage/myisam/sp_test.c
storage/myisam/rt_test.c
storage/myisam/mi_dynrec.c
sql/sql_plugin.cc
sql/sql_select.cc
sql/repl_failsafe.cc
sql/slave.cc

Have you considered removing those as well?

There's also a block in sql_parse.cc disabled by
NOT_NECESSARY_TO_CHECK_CREATE_TABLE_EXIST_WHEN_PREPARING_STATEMENT
that has not been active for several years from what I can see.

--- Jon Olav
Thread
bzr commit into mysql-trunk-bugfixing branch (davi:3131) WL#5498Davi Arnaut20 Jul
Re: bzr commit into mysql-trunk-bugfixing branch (davi:3131) WL#5498Jon Olav Hauglid20 Jul