List:Commits« Previous MessageNext Message »
From:Konstantin Osipov Date:July 19 2010 7:35am
Subject:Re: bzr commit into mysql-5.1-bugteam branch (jon.hauglid:3488)
Bug#54734
View as plain text  
* Jon Olav Hauglid <jon.hauglid@stripped> [10/07/16 13:22]:
>  3488 Jon Olav Hauglid	2010-07-16
>       Bug #54734 assert in Diagnostics_area::set_ok_status
>       
>       This assert checks that the server does not try to send OK to the
>       client if there has been some error during processing. This to make
>       sure that the error is in fact sent to the client.

This to make sure -> The is done to make sure

>       The problem was that view errors during processing of WHERE conditions
>       in UPDATE statements where not detected by the update code. It therefore
>       tried to send OK to the client, triggering the assert.
>       The bug was only noticeable in debug builds.
>       
>       This patch fixes the problem by making sure that the update code
>       checks for errors during condition processing and acts accordingly.

The patch is very nice and is OK to push.

>     modified:
>       mysql-test/r/update.result
>       mysql-test/t/update.test
>       sql/filesort.cc
>       sql/opt_range.h
>       sql/sql_delete.cc
>       sql/sql_select.cc
>       sql/sql_update.cc

-- 
Thread
bzr commit into mysql-5.1-bugteam branch (jon.hauglid:3488) Bug#54734Jon Olav Hauglid16 Jul
  • Re: bzr commit into mysql-5.1-bugteam branch (jon.hauglid:3488)Bug#54734Konstantin Osipov19 Jul