List:Commits« Previous MessageNext Message »
From:Libing Song Date:July 9 2010 2:49am
Subject:Re: bzr commit into mysql-trunk-bugfixing branch (luis.soares:3102)
Bug#54744
View as plain text  
Hi Luis,
Patch approved.

By the way,
I think we use too much 'exit(1)' in mysqlbinlog's code. It is bad.
If we have time it should be refactoring.

On Thu, 2010-07-08 at 22:40 +0000, Luis Soares wrote:
> #At
> file:///home/lsoares/Workspace/bzr/work/bugfixing/54744/push/mysql-trunk-bugfixing/ based
> on revid:luis.soares@stripped
> 
>  3102 Luis Soares	2010-07-08
>       BUG#54744: valgrind reports leak for mysqlbinlog
>             
>       The server was not cleaning up some dbug allocated memory 
>       before exiting. This is not a real problem, as this memory 
>       would be deallocated anyway. Nonetheless, we improve the 
>       mysqlbinlog exit procedure, wrt to memory book-keeping, when 
>       no parameter is given.
>             
>       To fix this, we deploy a call to my_end() before the
>       thread exits.
> 
>     modified:
>       client/mysqlbinlog.cc
> === modified file 'client/mysqlbinlog.cc'
> --- a/client/mysqlbinlog.cc	2010-07-08 16:30:19 +0000
> +++ b/client/mysqlbinlog.cc	2010-07-08 22:40:48 +0000
> @@ -2032,6 +2032,7 @@ int main(int argc, char** argv)
>    {
>      usage();
>      free_defaults(defaults_argv);
> +    my_end(my_end_arg);
>      exit(1);
>    }
>  
> 
> text/bzr-bundle type attachment
> (bzr/luis.soares@stripped)
> # Bazaar merge directive format 2 (Bazaar 0.90)
> # revision_id: luis.soares@stripped
> # target_branch: file:///home/lsoares/Workspace/bzr/work/bugfixing\
> #   /54744/push/mysql-trunk-bugfixing/
> # testament_sha1: c22a4c809880ca79f007295fc8d001ba32396dc2
> # timestamp: 2010-07-08 23:40:52 +0100
> # source_branch: /home/lsoares/Workspace/bzr/clones/mysql-trunk-\
> #   bugfixing
> # base_revision_id: luis.soares@stripped\
> #   abkifnmkjr9k1njs
> # 
> # Begin bundle
> IyBCYXphYXIgcmV2aXNpb24gYnVuZGxlIHY0CiMKQlpoOTFBWSZTWVuWcm8AAZFfgFAQWGf//1KF
> DgC////wUAQmO9453nV7R3t2d24SiEaieTEMEyPVPSaAyaNADRkEpEAm02k0TUPSDyjIaBoAGgEk
> KMp5J6jTRqjaQaeUeSepoaAGQBIqaEwJHlHqHlGnqPU0NBkNAABJIUaYFHphJhPJPUGmgeoAA0ak
> t1q+34bbTPvzsTLXMZJwL7bmq1jjR4sDkz4Y0SJJbPKxVUf6JxdHr1tKHObxqVZsVduC2xcI6Ues
> a6fgfI6Li0dpEZwPEfmuE7jR4OOU/s9FumnENunfju48e4dhd8+xqdNXjtH3aiQrxG31i668Lo/R
> 4buqT2z0urkjWC2PLHdzvFwbyjswjwuftEWHXQHchchQkRcTEMRqCjsE4sqFBrncQhs5mX3F/W4p
> JKq7ado1pmlvCnd0ShicdW9Frp3Rz5CqJ48vCMUGEWJ+HEKeuYS+xV4n2yoPkpmDgKx1lTyVI1j7
> r4DCzEaNEnSOXDgSIt03WKJGYs0CpQQKrOgRcQ00ilUu6StbSBrNu8SXHBaKgkisBitTjn3kL2YP
> M7hCQgxTEd/VW4k+MrSNkLDTcw18zUZbISkIlrgfI0VnhXaQGBKDXYscJjG+pfYg9Qa8GpTBx7Ux
> aVyKwPKEzuMmCXM9ewz8d1Grfgy/zx7UiShjbw9ofcKyRvCnvVc+NCTc0xlWDg7c/SQ1wNoX7t1C
> 1s682wGnLbQ2muOtXOxyibgTlziwJBW6u+kvIbKrCiggPJlTBndoEvPBCkNM7nq4zHBpSO2aBz1u
> PBNzV5eZrJ1oRC2bC5rSlqkmWqYlsI0y7Ho2JFxzosDfFchnWe0hPDClkTepXUy8GlKXX4Gyx8xr
> bXoBz5G5NzozYx3JfayvZE1ZQqZq92kYVp3J1LZbiNBMs2h1sH6X2VXOiBSUUKqAXqNQqMcblc40
> 3OgTDRPzZkIZhIwyutFOw68FiqUYmCDHR2aTPSJpw0HIcKHdL3HS1aYz2lRTuwTUxcxtDeNUoFhJ
> AJ5ebL50I9brM2gNU/UMzkjWDpFqvzmazEY7qwrC+923uB+BScvLpDZcFQbueinDALAog8IIogte
> 7nlng9I9DJqC5GUWIbTYOLKrARyifEnVYs1sH4nVrCdVKZPR48ro24+gpoq+5IdTwvvGBrh0Su6B
> FBFISRkYEGTKLJv6zj6DhckW6RhkU7EiDTBv59OImyAqEC9GpOS63zVvnSouVUaYq0lfqePf0Cef
> bowFXDe4SCAjJy3da9DMCt5oIpz9z0VjO9z0izlIk7ibrUMUG2Q6RckPCT7A1WzF2QaqA51q8kib
> LqeQqzuE6Q/Uh1WWkXJiEb1lzgT2bhtYexrySyTE2UlCYLMuRnp1aVxwoSHEuEiRHK7M99KqX2MQ
> lmy5ZP86d7TFQwY5Nm3NZHsHFjlKpXj/i7kinChILcs5N4A=
> 
> 

-- 
Your Sincerely,
Libing Song
==================================
MySQL Replication Team
Software Engineer


Email : Li-Bing.Song@stripped
Skype : libing.song
MSN   : slb_database@stripped
Phone : +86 010-6505-4020 ext. 319
Mobile: +86 138-1144-2038
==================================

Thread
bzr commit into mysql-trunk-bugfixing branch (luis.soares:3102)Bug#54744Luis Soares9 Jul
  • Re: bzr commit into mysql-trunk-bugfixing branch (luis.soares:3102)Bug#54744Libing Song9 Jul