List:Commits« Previous MessageNext Message »
From:marko.makela Date:June 21 2010 9:40am
Subject:bzr commit into mysql-5.1-innodb branch (marko.makela:3515) Bug#54658
View as plain text  
#At file:///home/marko/innobase/dev/mysql2a/5.1-innodb/ based on revid:vasil.dimov@stripped9cbhedqea96

 3515 Marko Mäkelä	2010-06-21
      Bug #54658: InnoDB: Warning: allocated tablespace %lu, old maximum was 0
      
      dict_check_tablespaces_and_store_max_id(): Initialize max_space_id
      and fil_system->max_assigned_id from DICT_HDR_MAX_SPACE_ID.
      
      fil_space_create(): Suppress the warning unless !recv_recovery_on
      (do not complain while applying the redo log).

    modified:
      storage/innodb_plugin/dict/dict0load.c
      storage/innodb_plugin/fil/fil0fil.c
=== modified file 'storage/innodb_plugin/dict/dict0load.c'
--- a/storage/innodb_plugin/dict/dict0load.c	revid:vasil.dimov@oracle.com-20100618085155-xnm469cbhedqea96
+++ b/storage/innodb_plugin/dict/dict0load.c	revid:marko.makela@strippedom-20100621094008-o9fa153s3f09merw
@@ -316,7 +316,7 @@ dict_check_tablespaces_and_store_max_id(
 	dict_index_t*	sys_index;
 	btr_pcur_t	pcur;
 	const rec_t*	rec;
-	ulint		max_space_id	= 0;
+	ulint		max_space_id;
 	mtr_t		mtr;
 
 	mutex_enter(&(dict_sys->mutex));
@@ -327,6 +327,11 @@ dict_check_tablespaces_and_store_max_id(
 	sys_index = UT_LIST_GET_FIRST(sys_tables->indexes);
 	ut_a(!dict_table_is_comp(sys_tables));
 
+	max_space_id = mtr_read_ulint(dict_hdr_get(&mtr)
+				      + DICT_HDR_MAX_SPACE_ID,
+				      MLOG_4BYTES, &mtr);
+	fil_set_max_space_id_if_bigger(max_space_id);
+
 	btr_pcur_open_at_index_side(TRUE, sys_index, BTR_SEARCH_LEAF, &pcur,
 				    TRUE, &mtr);
 loop:

=== modified file 'storage/innodb_plugin/fil/fil0fil.c'
--- a/storage/innodb_plugin/fil/fil0fil.c	revid:vasil.dimov@stripped
+++ b/storage/innodb_plugin/fil/fil0fil.c	revid:marko.makela@oracle.com-20100621094008-o9fa153s3f09merw
@@ -1197,7 +1197,7 @@ try_again:
 	space->tablespace_version = fil_system->tablespace_version;
 	space->mark = FALSE;
 
-	if (UNIV_LIKELY(purpose == FIL_TABLESPACE)
+	if (UNIV_LIKELY(purpose == FIL_TABLESPACE && !recv_recovery_on)
 	    && UNIV_UNLIKELY(id > fil_system->max_assigned_id)) {
 		if (!fil_system->space_id_reuse_warned) {
 			fil_system->space_id_reuse_warned = TRUE;

Attachment: [text/bzr-bundle] bzr/marko.makela@oracle.com-20100621094008-o9fa153s3f09merw.bundle
Thread
bzr commit into mysql-5.1-innodb branch (marko.makela:3515) Bug#54658marko.makela21 Jun