List:Commits« Previous MessageNext Message »
From:Daogang Qu Date:June 11 2010 5:14am
Subject:Re: bzr commit into mysql-5.1-rep+2 branch (Dao-Gang.Qu:3185)
Bug#50935 WL#4033
View as plain text  
Luís Soares wrote:
>
>    RC4. In sql/mysqld.cc, hunk @@ -5739,7 +5739,8 @@,
>
>         I think "Allow" should be "Allows". 
>
> +   "Allow writing Rows_query_log events into binary log.",
>
>         But anyway, I am not a native speaker... Since this is a
>         user facing text, please ask Jon/Paul to have a look.
>  
>    

I'm using "Allow writing of Rows_query_log events into binary log."
as Jon recommended and it's more like a instruction in the context.


[12:34] <jon> daogang: "Allow writing of Rows_query_log events into 
binary log." might be a tiny bit better, otherwise -- go with it happy
[12:34] <jon> help info msg approved happy
[12:34] <jon> and thanks for asking!
[12:34] <daogang> jon: Thanks!
[12:36] <daogang> jon: will take it. Luis want replace 'Allow' with 
'Allows'. Which one is better from a native speaker?
[12:36] <jon> daogang: 不客气
[12:37] <jon> daogang: oh! well, either is fine: "allow" would be more 
like an instruction, "allows" = a statement of fact
[12:37] <jon> unfortunately, I've seen both styles used in our help 
messages etc, even though we should really use one or the other consistently
[12:38] <jon> If Luís wants to use "Allows", I have no objection...
[12:38] <daogang> jon: Yes. I think so.
[12:38] *** jon really needs to ask Paul to look into this with dev team 
leads etc

Best Regards,

Daogang
Thread
bzr commit into mysql-5.1-rep+2 branch (Dao-Gang.Qu:3185) Bug#50935 WL#4033Dao-Gang.Qu28 May
  • Re: bzr commit into mysql-5.1-rep+2 branch (Dao-Gang.Qu:3185)Bug#50935 WL#4033He Zhenxing4 Jun
    • Re: bzr commit into mysql-5.1-rep+2 branch (Dao-Gang.Qu:3185)Bug#50935 WL#4033Daogang Qu6 Jun
    • Re: bzr commit into mysql-5.1-rep+2 branch (Dao-Gang.Qu:3185)Bug#50935 WL#4033Daogang Qu7 Jun
      • Re: bzr commit into mysql-5.1-rep+2 branch (Dao-Gang.Qu:3185)Bug#50935 WL#4033Luís Soares8 Jun
        • Re: bzr commit into mysql-5.1-rep+2 branch (Dao-Gang.Qu:3185)Bug#50935 WL#4033Daogang Qu9 Jun
    • Re: bzr commit into mysql-5.1-rep+2 branch (Dao-Gang.Qu:3185)Bug#50935 WL#4033Daogang Qu10 Jun
  • Re: bzr commit into mysql-5.1-rep+2 branch (Dao-Gang.Qu:3185)Bug#50935 WL#4033Luís Soares8 Jun
    • Re: bzr commit into mysql-5.1-rep+2 branch (Dao-Gang.Qu:3185)Bug#50935 WL#4033Daogang Qu10 Jun
    • Re: bzr commit into mysql-5.1-rep+2 branch (Dao-Gang.Qu:3185)Bug#50935 WL#4033Daogang Qu11 Jun