List:Commits« Previous MessageNext Message »
From:Georgi Kodinov Date:June 9 2010 8:41am
Subject:bzr commit into mysql-trunk-bugfixing branch (Georgi.Kodinov:3052)
View as plain text  
#At file:///home/kgeorge/mysql/work/B52512-trunk-merge/ based on revid:davi.arnaut@stripped

 3052 Georgi Kodinov	2010-06-09 [merge]
      merge

    modified:
      mysql-test/r/loaddata.result
      mysql-test/t/loaddata.test
      sql/net_serv.cc
      sql/sql_load.cc
=== modified file 'mysql-test/r/loaddata.result'
--- a/mysql-test/r/loaddata.result	2010-05-07 16:17:55 +0000
+++ b/mysql-test/r/loaddata.result	2010-06-09 08:41:24 +0000
@@ -496,4 +496,11 @@ SELECT * FROM t1;
 col0
 test
 DROP TABLE t1;
+#
+# Bug #52512 : Assertion `! is_set()' in 
+#  Diagnostics_area::set_ok_status on LOAD DATA
+#
+CREATE TABLE t1 (id INT NOT NULL);
+LOAD DATA LOCAL INFILE 'tb.txt' INTO TABLE t1;
+DROP TABLE t1;
 End of 5.1 tests

=== modified file 'mysql-test/t/loaddata.test'
--- a/mysql-test/t/loaddata.test	2010-05-12 11:13:47 +0000
+++ b/mysql-test/t/loaddata.test	2010-06-09 08:41:24 +0000
@@ -550,4 +550,24 @@ let $MYSQLD_DATADIR= `select @@datadir`;
 remove_file $MYSQLD_DATADIR/test/t1.txt;
 
 
+--echo #
+--echo # Bug #52512 : Assertion `! is_set()' in 
+--echo #  Diagnostics_area::set_ok_status on LOAD DATA
+--echo #
+
+connect (con1,localhost,root,,test);
+
+CREATE TABLE t1 (id INT NOT NULL);
+--send LOAD DATA LOCAL INFILE 'tb.txt' INTO TABLE t1
+# please keep this is a spearate test file : it's important to have no
+# commands after this one
+
+connection default;
+dirty_close con1;
+
+connect (con1,localhost,root,,test);
+DROP TABLE t1;
+connection default;
+disconnect con1;
+
 --echo End of 5.1 tests

=== modified file 'sql/net_serv.cc'
--- a/sql/net_serv.cc	2010-05-27 10:42:12 +0000
+++ b/sql/net_serv.cc	2010-06-09 08:41:24 +0000
@@ -920,7 +920,13 @@ my_real_read(NET *net, size_t *complen)
 		       ("Packets out of order (Found: %d, expected %u)",
 			(int) net->buff[net->where_b + 3],
 			net->pkt_nr));
-#ifdef EXTRA_DEBUG
+            /* 
+              We don't make noise server side, since the client is expected
+              to break the protocol for e.g. --send LOAD DATA .. LOCAL where
+              the server expects the client to send a file, but the client
+              may reply with a new command instead.
+            */
+#if defined (EXTRA_DEBUG) && !defined (MYSQL_SERVER)
             fflush(stdout);
 	    fprintf(stderr,"Error: Packets out of order (Found: %d, expected %d)\n",
 		    (int) net->buff[net->where_b + 3],

=== modified file 'sql/sql_load.cc'
--- a/sql/sql_load.cc	2010-05-31 10:59:58 +0000
+++ b/sql/sql_load.cc	2010-06-09 08:41:24 +0000
@@ -995,6 +995,10 @@ read_sep_field(THD *thd, COPY_INFO &info
         DBUG_RETURN(1);
       }
     }
+
+    if (thd->is_error())
+      read_info.error= 1;
+
     if (read_info.error)
       break;
     if (skip_lines)


Attachment: [text/bzr-bundle] bzr/georgi.kodinov@oracle.com-20100609084124-kmo69y336tc7w7ky.bundle
Thread
bzr commit into mysql-trunk-bugfixing branch (Georgi.Kodinov:3052) Georgi Kodinov9 Jun