List:Commits« Previous MessageNext Message »
From:marko.makela Date:May 25 2010 12:37pm
Subject:bzr commit into mysql-5.1-innodb branch (marko.makela:3481)
View as plain text  
#At file:///home/marko/innobase/dev/mysql2a/5.1-innodb/ based on revid:marko.makela@stripped52sz0yh4szkb

 3481 Marko Mäkelä	2010-05-25
      Suppress bogus Valgrind warnings about buf_buddy_relocate()
      accessing uninitialized memory in Valgrind-instrumented builds.

    modified:
      mysql-test/valgrind.supp
      storage/innodb_plugin/buf/buf0buddy.c
=== modified file 'mysql-test/valgrind.supp'
--- a/mysql-test/valgrind.supp	revid:marko.makela@strippedsz0yh4szkb
+++ b/mysql-test/valgrind.supp	revid:marko.makela@stripped
@@ -722,3 +722,8 @@
    fun:pthread_create*
 }
 
+{
+   buf_buddy_relocate peeking (space,page) in potentially free blocks
+   Memcheck:Addr1
+   fun:buf_buddy_relocate
+}

=== modified file 'storage/innodb_plugin/buf/buf0buddy.c'
--- a/storage/innodb_plugin/buf/buf0buddy.c	revid:marko.makela@oracle.com-20100524114349-5kaw52sz0yh4szkb
+++ b/storage/innodb_plugin/buf/buf0buddy.c	revid:marko.makela@strippedm-20100525123748-pmpehbg29oyhc1ns
@@ -442,11 +442,15 @@ buf_buddy_relocate(
 		pool), so there is nothing wrong about this.  The
 		mach_read_from_4() calls here will only trigger bogus
 		Valgrind memcheck warnings in UNIV_DEBUG_VALGRIND builds. */
-		bpage = buf_page_hash_get(
-			mach_read_from_4((const byte*) src
-					 + FIL_PAGE_ARCH_LOG_NO_OR_SPACE_ID),
-			mach_read_from_4((const byte*) src
-					 + FIL_PAGE_OFFSET));
+		ulint		space	= mach_read_from_4(
+			(const byte*) src + FIL_PAGE_ARCH_LOG_NO_OR_SPACE_ID);
+		ulint		page_no	= mach_read_from_4(
+			(const byte*) src + FIL_PAGE_OFFSET);
+		/* Suppress Valgrind warnings about conditional jump
+		on uninitialized value. */
+		UNIV_MEM_VALID(&space, sizeof space);
+		UNIV_MEM_VALID(&page_no, sizeof page_no);
+		bpage = buf_page_hash_get(space, page_no);
 
 		if (!bpage || bpage->zip.data != src) {
 			/* The block has probably been freshly

Attachment: [text/bzr-bundle] bzr/marko.makela@oracle.com-20100525123748-pmpehbg29oyhc1ns.bundle
Thread
bzr commit into mysql-5.1-innodb branch (marko.makela:3481) marko.makela25 May