List:Commits« Previous MessageNext Message »
From:marko.makela Date:May 20 2010 1:10pm
Subject:bzr push into mysql-5.1-innodb branch (marko.makela:3474 to 3475)
View as plain text  
 3475 Marko Mäkelä	2010-05-20
      buf_LRU_free_block(): Correct an error in the comment.

    modified:
      storage/innodb_plugin/buf/buf0lru.c
      storage/innodb_plugin/include/buf0lru.h
 3474 Marko Mäkelä	2010-05-20
      Bug#53593: Add some instrumentation to improve Valgrind sensitivity
      
      BUILD/*: Add valgrind_configs=--with-valgrind.
      BUILD/*: Remove -USAFEMALLOC from valgrind_flags.
      
      configure.in: Add AC_ARG_WITH(valgrind) and HAVE_VALGRIND.
      
      include/my_sys.h: Define a number of MEM_ wrappers for VALGRIND_ functions.
      include/my_sys.h: Make TRASH do MEM_UNDEFINED().
      
      include/m_string.h: Remove unused macro bzero_if_purify(A,B).
      
      _mymalloc(): Declare MEM_UNDEFINED() on the allocated memory.
      
      _myfree(): Declare MEM_NOACCESS() on the freed memory.
      
      storage/innobase/include/univ.i: Enable UNIV_DEBUG_VALGRIND based on
      HAVE_VALGRIND rather than HAVE_purify.
      
      Possible things to do:
       * In my_global.h, remove the defined(HAVE_purify) condition
         from the _WIN32 uint3korr().
       * In my_global.h *int*korr(), use | instead of +
         in order to keep the Valgrind V bits accurate
       * Consider replacing HAVE_purify with HAVE_VALGRIND
       * Use VALGRIND_CREATE_BLOCK, VALGRIND_DISCARD in mem_root and similar places

    modified:
      BUILD/SETUP.sh
      BUILD/build_mccge.sh
      BUILD/compile-amd64-valgrind-max
      BUILD/compile-pentium-icc-valgrind-max
      BUILD/compile-pentium-valgrind-max
      BUILD/compile-pentium-valgrind-max-no-ndb
      BUILD/compile-pentium64-valgrind-max
      configure.in
      include/m_string.h
      include/my_sys.h
      mysys/safemalloc.c
      storage/innobase/include/univ.i
      storage/innodb_plugin/include/univ.i
=== modified file 'storage/innodb_plugin/buf/buf0lru.c'
--- a/storage/innodb_plugin/buf/buf0lru.c	revid:marko.makela@stripped
+++ b/storage/innodb_plugin/buf/buf0lru.c	revid:marko.makela@oracle.com-20100520130734-ueow9mn60czp7o4m
@@ -1364,7 +1364,7 @@ buf_LRU_make_block_old(
 Try to free a block.  If bpage is a descriptor of a compressed-only
 page, the descriptor object will be freed as well.
 
-NOTE: If this function returns BUF_LRU_FREED, it will not temporarily
+NOTE: If this function returns BUF_LRU_FREED, it will temporarily
 release buf_pool_mutex.  Furthermore, the page frame will no longer be
 accessible via bpage.
 

=== modified file 'storage/innodb_plugin/include/buf0lru.h'
--- a/storage/innodb_plugin/include/buf0lru.h	revid:marko.makela@oracle.com-20100520104042-ma2nsscqdvwoph8k
+++ b/storage/innodb_plugin/include/buf0lru.h	revid:marko.makela@strippedom-20100520130734-ueow9mn60czp7o4m
@@ -96,7 +96,7 @@ buf_LRU_insert_zip_clean(
 Try to free a block.  If bpage is a descriptor of a compressed-only
 page, the descriptor object will be freed as well.
 
-NOTE: If this function returns BUF_LRU_FREED, it will not temporarily
+NOTE: If this function returns BUF_LRU_FREED, it will temporarily
 release buf_pool_mutex.  Furthermore, the page frame will no longer be
 accessible via bpage.
 

Attachment: [text/bzr-bundle] bzr/marko.makela@oracle.com-20100520130734-ueow9mn60czp7o4m.bundle
Thread
bzr push into mysql-5.1-innodb branch (marko.makela:3474 to 3475) marko.makela20 May