On Wed, May 19, 2010 at 03:55:48PM -0300, Davi Arnaut wrote:
>We usually use the syntax:
>
>Bug#nnnnn: Title
>
>in the first line.
Oh, I was following the 2004 practice. Will change that.
>>+#else /* HAVE_VALGRIND */
>>+# define MEM_UNDEFINED(a,len) ((void) 0)
>>+# define MEM_NOACCESS(a,len) ((void) 0)
>>+# define MEM_DEFINED_ADDRESSABLE(a,len) ((void) 0)
>>+# define MEM_DEFINED(a,len) ((void) 0)
>>+# define MEM_GET_VBITS(a,v,len) ((void) 0)
>>+# define MEM_SET_VBITS(a,v,len) ((void) 0)
>>+# define MEM_CHECK_ADDRESSABLE(a,len) ((void) 0)
>>+# define MEM_CHECK_DEFINED(a,len) ((void) 0)
>>+#endif /* HAVE_VALGRIND */
>
>Do you plan to use all of those soon? If no, please only keep those
>that are likely to be used in the near future.
Originally, I planned to use more. The MEM_CHECK_DEFINED is not yet
used, but I would keep it, because it is useful whenever you want to
check that an entire memory block is defined. I will remove the
MEM_DEFINED* and MEM_*ET_VBITS.
>No tabs in MySQL code.
>
>http://forge.mysql.com/wiki/MySQL_Internals_Coding_Guidelines
>
>Otherwise looks good. Thanks for working on this!
Sorry, I forgot about the tabs. There are quite a few already in
my_sys.h, and most comments are not aligned at column 48 :-) But I will
comply, of course.
Marko
