List:Commits« Previous MessageNext Message »
From:Guilhem Bichot Date:May 19 2010 7:01am
Subject:bzr push into mysql-next-mr-bugfixing branch (guilhem:3186 to 3187)
View as plain text  
 3187 Guilhem Bichot	2010-05-19
      disable unit test

    modified:
      mysys/waiting_threads.c
      unittest/mysys/waiting_threads-t.c
 3186 Guilhem Bichot	2010-05-18
      backport again.

    modified:
      include/my_global.h
=== modified file 'mysys/waiting_threads.c'
--- a/mysys/waiting_threads.c	2010-05-18 20:29:45 +0000
+++ b/mysys/waiting_threads.c	2010-05-19 07:01:11 +0000
@@ -225,10 +225,10 @@
 #endif
         }
   - ma_rc_dup_unique was:
-  /* a WT_RESOURCE_TYPE for transactions waiting on a unique key conflict * /
+  / * a WT_RESOURCE_TYPE for transactions waiting on a unique key conflict * /
   WT_RESOURCE_TYPE ma_rc_dup_unique={ wt_resource_id_memcmp, 0};
   - When a Maria transaction would commit or rollback it would call:
-  /* * Wake up threads waiting for this transaction * /
+  / * Wake up threads waiting for this transaction * /
   static void wt_thd_release_self(TRN *trn)
   {
     if (trn->wt)
@@ -241,6 +241,9 @@
     }
   }
 
+  Tests
+  ^^^^^
+  unittest/mysys/waiting_threads-t.c, currently disabled.
 */
 
 /*

=== modified file 'unittest/mysys/waiting_threads-t.c'
--- a/unittest/mysys/waiting_threads-t.c	2010-05-18 20:29:45 +0000
+++ b/unittest/mysys/waiting_threads-t.c	2010-05-19 07:01:11 +0000
@@ -16,6 +16,10 @@
 /*
   This is a unit test for the deadlock detector in mysys/waiting_thread.c and
   include/waiting_thread.h.
+  As the detector is not used in MySQL, and the test sometimes fails on some
+  platforms and we don't have time to investigate/fix it, this test is
+  compiled but not run (see start of do_tests()). Make sure to enable it if
+  you use the module.
 */
 
 #include "thr_template.c"
@@ -232,6 +236,9 @@ void do_one_test()
 void do_tests()
 {
   DBUG_ENTER("do_tests");
+
+  skip_all(": this module is not used in MySQL");
+
   plan(12);
   compile_time_assert(THREADS >= 4);
 


Attachment: [text/bzr-bundle] bzr/guilhem@mysql.com-20100519070111-nejs4nk5bxrw9ne0.bundle
Thread
bzr push into mysql-next-mr-bugfixing branch (guilhem:3186 to 3187) Guilhem Bichot19 May