List:Commits« Previous MessageNext Message »
From:Davi Arnaut Date:May 18 2010 1:31pm
Subject:Re: bzr commit into mysql-5.1-innodb branch (marko.makela:3464)
Bug#53593
View as plain text  
On 5/13/10 6:36 AM, Marko Mäkelä wrote:
> Hi Davi,
>
> I couldn't resist checking my email on a holiday :-)
>
> On Wed, May 12, 2010 at 07:39:39PM -0300, Davi Arnaut wrote:
>>> Like I wrote later in the bug report, I would not remove
>>> -UFORCE_INIT_OF_VARS after all. If we removed it, LINT_INIT would
>>> have to be edited to declare the variable uninitialized in Valgrind.
>>
>> I see, but my point is that FORCE_INIT_OF_VARS isn't really adequate
>> for valgrind. Presumably, it is used to silence where valgrind would
>> wrongly warn (false positive) about variables being used without being
>> initialized. But this should be silenced using the valgrind
>> suppression file, otherwise the valgrind warning would be relevant and
>> should be fixed.
>
> No, you got my point wrong. The patch as I posted it is not removing
> -DFORCE_INIT_OF_VARS but -UFORCE_INIT_OF_VARS. I think that the
> FORCE_INIT_OF_VARS (which enables LINT_INIT) is only needed to silence
> warnings from inaccurate static analysis tools.

Sorry, in retrospect, I should have been more clear. The variables 
debug_cflags and valgrind_flags are combined in some BUILD files (for 
example, compile-pentium-valgrind-max-no-ndb), so the -U is there to 
cancel its effect.

>> Agree? Bottom line, do you see any valgrind warnings if the
>> initialization of variables is not forced?
>
> Currently, the initialization of variables is not forced when compiling
> for Valgrind, and I hope we are not seeing (m)any Valgrind warnings due
> to that.

I agree. But that's only guaranteed in some BUILD files by the -U.

Regards,

Davi

Thread
bzr commit into mysql-5.1-innodb branch (marko.makela:3464) Bug#53593marko.makela12 May
  • Re: bzr commit into mysql-5.1-innodb branch (marko.makela:3464)Bug#53593Davi Arnaut12 May
    • Re: bzr commit into mysql-5.1-innodb branch (marko.makela:3464)Bug#53593Marko Mäkelä12 May
      • Re: bzr commit into mysql-5.1-innodb branch (marko.makela:3464)Bug#53593Davi Arnaut13 May
        • Re: bzr commit into mysql-5.1-innodb branch (marko.makela:3464)Bug#53593Marko Mäkelä13 May
          • Re: bzr commit into mysql-5.1-innodb branch (marko.makela:3464)Bug#53593Davi Arnaut18 May
        • Re: bzr commit into mysql-5.1-innodb branch (marko.makela:3464)Bug#53593Marko Mäkelä13 May
        • Re: bzr commit into mysql-5.1-innodb branch (marko.makela:3464)Bug#53593Marko Mäkelä14 May
          • Re: bzr commit into mysql-5.1-innodb branch (marko.makela:3464)Bug#53593Davi Arnaut18 May
        • Re: bzr commit into mysql-5.1-innodb branch (marko.makela:3464)Bug#53593Marko Mäkelä14 May
    • Re: bzr commit into mysql-5.1-innodb branch (marko.makela:3464)Bug#53593Marko Mäkelä12 May