List:Commits« Previous MessageNext Message »
From:Ingo Strüwing Date:May 5 2010 11:16am
Subject:Re: bzr commit into mysql-5.1 branch (Rafal.Somla:3450)
View as plain text  
Hi Rafal,

there are two small things, which I have overlooked during my review:

Rafal Somla, 04.05.2010 13:58:

...
> === added file 'mysql-test/include/have_meb.inc'


I suggest to move that file to mysql-test/suite/meb/include/.
Outside of that suite, no test should ever want to call it.

...
> +if (`select '$IBBACKUP'='' OR '$INNOBACKUP'=''`)
> +{
> +--skip You must set IBBACKUP and INNOBACKUP variables to run this test.


I suggest to indent this.

...

Regards
Ingo
-- 
Ingo Strüwing, Database Group
Sun Microsystems GmbH, Sonnenallee 1, D-85551 Kirchheim-Heimstetten
Geschäftsführer: Jürgen Kunz                     HRB München 161028
Thread
bzr commit into mysql-5.1 branch (Rafal.Somla:3450)Rafal Somla4 May
  • Re: bzr commit into mysql-5.1 branch (Rafal.Somla:3450)Ingo Strüwing4 May
    • Re: bzr commit into mysql-5.1 branch (Rafal.Somla:3450)Rafal Somla4 May
      • Re: bzr commit into mysql-5.1 branch (Rafal.Somla:3450)Ingo Strüwing4 May
  • Re: bzr commit into mysql-5.1 branch (Rafal.Somla:3450)Ingo Strüwing5 May