List:Commits« Previous MessageNext Message »
From:marko.makela Date:May 4 2010 12:56pm
Subject:bzr push into mysql-5.1-innodb branch (marko.makela:3439 to 3440)
View as plain text  
 3440 Marko Mäkelä	2010-05-04
      Add Valgrind checks to catch uninitialized writes to data files.
      buf_flush_insert_into_flush_list(),
      buf_flush_insert_sorted_into_flush_list(),
      buf_flush_post_to_doublewrite_buf(): Check that the page is initialized.

    modified:
      storage/innobase/buf/buf0flu.c
 3439 Marko Mäkelä	2010-05-04
      Add Valgrind checks to catch uninitialized writes to data files.
      buf_flush_insert_into_flush_list(),
      buf_flush_insert_sorted_into_flush_list(),
      buf_flush_post_to_doublewrite_buf(): Check that the page is initialized.

    modified:
      storage/innodb_plugin/buf/buf0flu.c
=== modified file 'storage/innobase/buf/buf0flu.c'
--- a/storage/innobase/buf/buf0flu.c	2007-01-18 21:27:31 +0000
+++ b/storage/innobase/buf/buf0flu.c	2010-05-04 12:55:10 +0000
@@ -55,6 +55,7 @@ buf_flush_insert_into_flush_list(
 	      || (ut_dulint_cmp((UT_LIST_GET_FIRST(buf_pool->flush_list))
 				->oldest_modification,
 				block->oldest_modification) <= 0));
+	UNIV_MEM_ASSERT_RW(block->frame, UNIV_PAGE_SIZE);
 
 	UT_LIST_ADD_FIRST(flush_list, buf_pool->flush_list, block);
 
@@ -75,6 +76,7 @@ buf_flush_insert_sorted_into_flush_list(
 	buf_block_t*	b;
 
 	ut_ad(mutex_own(&(buf_pool->mutex)));
+	UNIV_MEM_ASSERT_RW(block->frame, UNIV_PAGE_SIZE);
 
 	prev_b = NULL;
 	b = UT_LIST_GET_FIRST(buf_pool->flush_list);
@@ -423,6 +425,7 @@ try_again:
 		goto try_again;
 	}
 
+	UNIV_MEM_ASSERT_RW(block->frame, UNIV_PAGE_SIZE);
 	ut_memcpy(trx_doublewrite->write_buf
 		  + UNIV_PAGE_SIZE * trx_doublewrite->first_free,
 		  block->frame, UNIV_PAGE_SIZE);

Attachment: [text/bzr-bundle] bzr/marko.makela@oracle.com-20100504125510-gemcfhj7mefrhalo.bundle
Thread
bzr push into mysql-5.1-innodb branch (marko.makela:3439 to 3440) marko.makela4 May