List:Commits« Previous MessageNext Message »
From:Bjorn Munch Date:May 3 2010 12:36pm
Subject:bzr commit into mysql-trunk branch (Bjorn.Munch:3009)
View as plain text  
#At file:///home/bm136801/my/myisam-tr/ based on revid:alik@stripped

 3009 Bjorn Munch	2010-05-03
      WV #5349 Change default storage engine to InnoDB
      Explicitly set default st.eng. to MyISAM for non-innodb tests
      Allow this to be changed with --[no]default-myisam

    modified:
      mysql-test/lib/mtr_cases.pm
      mysql-test/mysql-test-run.pl
=== modified file 'mysql-test/lib/mtr_cases.pm'
--- a/mysql-test/lib/mtr_cases.pm	2010-03-03 19:22:02 +0000
+++ b/mysql-test/lib/mtr_cases.pm	2010-05-03 12:35:09 +0000
@@ -41,6 +41,7 @@ our $opt_with_ndbcluster_only;
 our $defaults_file;
 our $defaults_extra_file;
 our $quick_collect;
+our $default_myisam= 0;		# Change to 1 when default default is innodb
 
 sub collect_option {
   my ($opt, $value)= @_;
@@ -591,6 +592,9 @@ sub optimize_cases {
       my $default_engine=
 	mtr_match_prefix($opt, "--default-storage-engine=");
 
+      # Allow use of uppercase, convert to all lower case
+      $default_engine =~ tr/A-Z/a-z/;
+
       if (defined $default_engine){
 
 	#print " $tinfo->{name}\n";
@@ -946,10 +950,12 @@ sub collect_one_test_case {
       return $tinfo unless $do_innodb_plugin;
     }
   }
-  else
+  elsif ($default_myisam)
   {
-    push(@{$tinfo->{'master_opt'}}, "--loose-skip-innodb");
-    push(@{$tinfo->{'slave_opt'}}, "--loose-skip-innodb");
+    # This is a temporary fix to allow non-innodb tests to run even if
+    # the default default storage engine is innodb.
+    push(@{$tinfo->{'master_opt'}}, "--default-storage-engine=MyISAM");
+    push(@{$tinfo->{'slave_opt'}}, "--default-storage-engine=MyISAM");
   }
 
   if ( $tinfo->{'need_binlog'} )

=== modified file 'mysql-test/mysql-test-run.pl'
--- a/mysql-test/mysql-test-run.pl	2010-03-15 13:57:20 +0000
+++ b/mysql-test/mysql-test-run.pl	2010-05-03 12:35:09 +0000
@@ -943,6 +943,7 @@ sub command_line_setup {
 	     'timestamp'                => \&report_option,
 	     'timediff'                 => \&report_option,
 	     'max-connections=i'        => \$opt_max_connections,
+	     'default-myisam!'          => \&collect_option,
 
              'help|h'                   => \$opt_usage,
              'list-options'             => \$opt_list_options,
@@ -2823,7 +2824,6 @@ sub mysql_install_db {
   mtr_add_arg($args, "--bootstrap");
   mtr_add_arg($args, "--basedir=%s", $install_basedir);
   mtr_add_arg($args, "--datadir=%s", $install_datadir);
-  mtr_add_arg($args, "--loose-innodb=OFF");
   mtr_add_arg($args, "--loose-skip-falcon");
   mtr_add_arg($args, "--loose-skip-ndbcluster");
   mtr_add_arg($args, "--tmpdir=%s", "$opt_vardir/tmp/");
@@ -5539,6 +5539,8 @@ Misc options
   timediff              With --timestamp, also print time passed since
                         *previous* test started
   max-connections=N     Max number of open connection to server in mysqltest
+  default-myisam        Set default storage engine to MyISAM for non-innodb
+                        tests. This is needed after switching default default.
 
 HERE
   exit(1);


Attachment: [text/bzr-bundle] bzr/bjorn.munch@sun.com-20100503123509-2lo94pau6sfdvg09.bundle
Thread
bzr commit into mysql-trunk branch (Bjorn.Munch:3009) Bjorn Munch3 May