From: Marc Alff
Date: April 20 2010 12:52pm
Subject: Re: bzr commit into mysql-trunk-innodb branch (vasil.dimov:3035)
List-Archive: http://lists.mysql.com/commits/106101
Message-Id: <4BCDA374.9070402@oracle.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit


Hi Vasil

On 4/20/10 6:29 AM, vasil.dimov@stripped wrote:
> #At file:///usr/local/devel/bzrroot/server/mysql-trunk-innodb/ based on revid:vasil.dimov@stripped
>
>   3035 Vasil Dimov	2010-04-20
>        Adjust the result for the mysql-test sys_vars.all_vars after the
>        addition of a new config variable.
>
>      modified:
>        mysql-test/suite/sys_vars/r/all_vars.result
> === modified file 'mysql-test/suite/sys_vars/r/all_vars.result'
> --- a/mysql-test/suite/sys_vars/r/all_vars.result	2010-04-14 11:53:08 +0000
> +++ b/mysql-test/suite/sys_vars/r/all_vars.result	2010-04-20 12:29:06 +0000
> @@ -13,8 +13,10 @@ There should be *no* variables listed be
>   INNODB_USE_NATIVE_AIO
>   INNODB_PURGE_THREADS
>   INNODB_PURGE_BATCH_SIZE
> +INNODB_BUFFER_POOL_INSTANCES
>   INNODB_USE_NATIVE_AIO
>   INNODB_PURGE_THREADS
>   INNODB_PURGE_BATCH_SIZE
> +INNODB_BUFFER_POOL_INSTANCES
>   drop table t1;
>   drop table t2;

The whole point of the all_vars test is to make sure every system 
variable is covered, hence the check that reads "There should be *no* 
variables listed ..."

The proper way to make this test pass is to write test cases for the 
missing variables, not to add exceptions.

Regards,
-- Marc