From: Marc Alff
Date: April 20 2010 9:07am
Subject: Re: bzr commit into mysql-next-mr-bugfixing branch (marc.alff:3160)
 Bug#46792
List-Archive: http://lists.mysql.com/commits/106076
Message-Id: <4BCD6EE3.4010903@oracle.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit


Hi Kevin

On 4/19/10 10:03 AM, Kevin Lewis wrote:
> Marc,
>
> The code I saw looks OK.  I agree that the old references to the obsolete bugs should be maintained since storage engines can use them.  After some time though these obsolete references should be cleaned from the code.
>
> I searched for all references to the old error names, for example; ER_COL_COUNT_DOESNT_MATCH_CORRUPTED.  And I found some references that you did not address.  Here they are.  Can you tell me why?
>
>    include\mysqld_ername.h(550):{ "ER_COL_COUNT_DOESNT_MATCH_CORRUPTED", 1547, "Column count of mysql.%s is wrong. Expected %d, found %d. The table is probably corrupted" },
>
>    include\mysqld_error.h(551):#define ER_COL_COUNT_DOESNT_MATCH_CORRUPTED 1547

These two files are automatically generated, and do not need to be 
changed: a full build will fix that.

>
> I can understand leaving the old ones, but shoul you also add the new error code here?

Likewise.

>
> That is the only problem I can find in code review.

Then the code is approved.
Thanks for the review.

Regards,
-- Marc