List:Commits« Previous MessageNext Message »
From:Marc Alff Date:April 20 2010 9:07am
Subject:Re: bzr commit into mysql-next-mr-bugfixing branch (marc.alff:3160)
Bug#46792
View as plain text  
Hi Kevin

On 4/19/10 10:03 AM, Kevin Lewis wrote:
> Marc,
>
> The code I saw looks OK.  I agree that the old references to the obsolete bugs should
> be maintained since storage engines can use them.  After some time though these obsolete
> references should be cleaned from the code.
>
> I searched for all references to the old error names, for example;
> ER_COL_COUNT_DOESNT_MATCH_CORRUPTED.  And I found some references that you did not
> address.  Here they are.  Can you tell me why?
>
>    include\mysqld_ername.h(550):{ "ER_COL_COUNT_DOESNT_MATCH_CORRUPTED", 1547,
> "Column count of mysql.%s is wrong. Expected %d, found %d. The table is probably
> corrupted" },
>
>    include\mysqld_error.h(551):#define ER_COL_COUNT_DOESNT_MATCH_CORRUPTED 1547

These two files are automatically generated, and do not need to be 
changed: a full build will fix that.

>
> I can understand leaving the old ones, but shoul you also add the new error code
> here?

Likewise.

>
> That is the only problem I can find in code review.

Then the code is approved.
Thanks for the review.

Regards,
-- Marc
Thread
bzr commit into mysql-next-mr-bugfixing branch (marc.alff:3160)Bug#46792Marc Alff16 Apr
  • RE: bzr commit into mysql-next-mr-bugfixing branch (marc.alff:3160)Bug#46792Kevin Lewis19 Apr
    • Re: bzr commit into mysql-next-mr-bugfixing branch (marc.alff:3160)Bug#46792Marc Alff20 Apr