List:Commits« Previous MessageNext Message »
From:Sergey Vojtovich Date:April 14 2010 10:11am
Subject:Re: bzr commit into mysql-5.1-bugteam branch (svoj:3436) Bug#39053
View as plain text  
Hi Ingo,

done.

Thanks,
Sergey

On Tue, Apr 13, 2010 at 05:10:47PM +0200, Ingo Strüwing wrote:
> Hi Sergey,
> 
> approved with minor suggestions. Please see below.
> 
> Sergey Vojtovich, 13.04.2010 13:10:
> 
> ...
> >  3436 Sergey Vojtovich	2010-04-13
> >       BUG#39053 - UNISTALL PLUGIN does not allow the storage engine
> >                   to cleanup open connections
> ...
> > +void thd_set_ha_data(THD *thd, const struct handlerton *hton,
> > +                     const void *ha_data)
> > +{
> > +  if (ha_data && !thd->ha_data[hton->slot].lock)
> > +    thd->ha_data[hton->slot].lock=
> > +      ha_lock_engine(NULL, (handlerton*) hton);
> > +  else if (!ha_data && thd->ha_data[hton->slot].lock)
> > +  {
> > +    plugin_unlock(NULL, thd->ha_data[hton->slot].lock);
> > +    thd->ha_data[hton->slot].lock= NULL;
> > +  }
> > +  *thd_ha_data(thd, hton)= (void*) ha_data;
> > +}
> 
> 
> thd->ha_data[hton->slot] is used frequently enough in this function to
> make it worth to set up a local pointer for it.
> 
> > +
> > +
> >  extern "C"
> >  long long thd_test_options(const THD *thd, long long test_options)
> >  {
> > 
> > === modified file 'sql/sql_class.h'
> > --- a/sql/sql_class.h	2010-03-29 02:32:30 +0000
> > +++ b/sql/sql_class.h	2010-04-13 11:10:35 +0000
> > @@ -1264,7 +1264,11 @@ struct Ha_data
> >      @sa trans_register_ha()
> >    */
> >    Ha_trx_info ha_info[2];
> > -
> > +  /**
> > +    NULL: engine is not bound to this thread
> > +    non-NULL: engine is bount to this thread, engine shutdown forbidden
> 
> 
> Typo: bount -> bound
> 
> ...
> 
> Please report a bug for the engine change(s) and reference it in
> Bug#39053. Then I will mark my approval in the bug report.
> 
> Regards
> Ingo
> -- 
> Ingo Strüwing, Database Group
> Sun Microsystems GmbH, Sonnenallee 1, D-85551 Kirchheim-Heimstetten
> Geschäftsführer: Jürgen Kunz                     HRB München
> 161028
> 
> -- 
> MySQL Code Commits Mailing List
> For list archives: http://lists.mysql.com/commits
> To unsubscribe:    http://lists.mysql.com/commits?unsub=1
> 

-- 
Sergey Vojtovich <svoj@stripped>
MySQL AB, Software Engineer
Izhevsk, Russia, www.mysql.com
Thread
bzr commit into mysql-5.1-bugteam branch (svoj:3436) Bug#39053Sergey Vojtovich13 Apr
  • Re: bzr commit into mysql-5.1-bugteam branch (svoj:3436) Bug#39053Ingo Strüwing13 Apr
    • Re: bzr commit into mysql-5.1-bugteam branch (svoj:3436) Bug#39053Sergey Vojtovich14 Apr