List:Commits« Previous MessageNext Message »
From:Reggie Burnett Date:March 8 2010 9:15pm
Subject:bzr commit into connector-net-6.0 branch (reggie.burnett:799) Bug#49850
View as plain text  
#At file:///D:/bzr-connector-net/6.0/ based on revid:reggie.burnett@stripped

  799 Reggie Burnett	2010-03-08
      - fixed bug in sql generation when using a negated binary fragment in EF (bug #49850)

    modified:
      CHANGES
      MySql.Data.Entity/Provider/Fragments/SqlFragment.cs
=== modified file 'CHANGES'
=== modified file 'CHANGES'
--- a/CHANGES	2010-03-03 23:36:25 +0000
+++ b/CHANGES	2010-03-08 21:15:52 +0000
@@ -23,6 +23,7 @@
   query builder (bug #50171)
 - ScriptCompleted event handler now uses EventArgs.Empty instead of null
 - fixed parsing bug that was caused by special characters being jammed up beside a quoted identifier (bug #51610)
+- fixed bug in sql generation when using a negated binary fragment in EF (bug #49850)
 
 Version 6.0.5
 - ensure that MySqlPacket always has a valid encoding. This prevents null reference exceptions in ReadString()

=== modified file 'MySql.Data.Entity/Provider/Fragments/SqlFragment.cs'
--- a/MySql.Data.Entity/Provider/Fragments/SqlFragment.cs	2010-02-12 18:11:12 +0000
+++ b/MySql.Data.Entity/Provider/Fragments/SqlFragment.cs	2010-03-08 21:15:52 +0000
@@ -66,7 +66,7 @@
         public override void WriteSql(StringBuilder sql)
         {
             if (IsNegated)
-                sql.Append("NOT ");
+                sql.Append("NOT (");
 
             // do left arg
             if (WrapLeft)
@@ -83,6 +83,8 @@
             Right.WriteSql(sql);
             if (WrapRight)
                 sql.Append(")");
+            if (IsNegated)
+                sql.Append(")");
         }
     }
 


Attachment: [text/bzr-bundle] bzr/reggie.burnett@sun.com-20100308211552-az44vidj4edm9qbk.bundle
Thread
bzr commit into connector-net-6.0 branch (reggie.burnett:799) Bug#49850Reggie Burnett8 Mar